feat: add RDS primary key transformer #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phani-srikar
changed the title
phani-srikar
force-pushed
the
rds-primary-key-index-transformer
branch
from
0bedac2
to
26360c3
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## feature/rds-support #1216 +/- ##
====================================================
Coverage 63.42% 63.42%
====================================================
Files 297 297
Lines 18931 18931
Branches 4573 4573
====================================================
Hits 12007 12007
Misses 6309 6309
Partials 615 615 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marcvberg
reviewed
Jan 31, 2023
packages/amplify-graphql-index-transformer/src/graphql-index-transformer.ts
Outdated
Show resolved
Hide resolved
marcvberg
reviewed
Jan 31, 2023
packages/amplify-graphql-index-transformer/src/graphql-primary-key-transformer.ts
Show resolved
Hide resolved
marcvberg
approved these changes
Jan 31, 2023
sundersc
reviewed
Jan 31, 2023
Comment on lines
+39
to
+61
| if (getResolver) { | ||
| addIndexToResolverSlot(getResolver, [primaryKeySnippet]); | ||
| } | ||
|
|
||
| if (listResolver) { | ||
| const sortDirectionValidation = printBlock('Validate the sort direction input')(compoundExpression(validateSortDirectionInput(config, true))); | ||
| addIndexToResolverSlot(listResolver, [ | ||
| primaryKeySnippet, | ||
| sortDirectionValidation | ||
| ]); | ||
| } | ||
|
|
||
| if (createResolver) { | ||
| addIndexToResolverSlot(createResolver, [primaryKeySnippet]); | ||
| } | ||
|
|
||
| if (updateResolver) { | ||
| addIndexToResolverSlot(updateResolver, [primaryKeySnippet]); | ||
| } | ||
|
|
||
| if (deleteResolver) { | ||
| addIndexToResolverSlot(deleteResolver, [primaryKeySnippet]); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Do we need these for RDS?
There was a problem hiding this comment.
Yes we do, in order to set the keys metadata which is later used in lambda to set WHERE conditions based on the columns used in primary key.
sundersc
reviewed
Jan 31, 2023
packages/amplify-graphql-index-transformer/src/resolvers/generators/rds-vtl-generator.ts
Outdated
Show resolved
Hide resolved
sundersc
reviewed
Jan 31, 2023
packages/amplify-graphql-index-transformer/src/resolvers/generators/vtl-generator.ts
Outdated
Show resolved
Hide resolved
sundersc
approved these changes
Feb 1, 2023
phani-srikar
force-pushed
the
rds-primary-key-index-transformer
branch
from
c7667cf
to
17a9e06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
CDK / CloudFormation Parameters Changed
Issue #, if available
Description of how you validated changes
Expanded the current unit tests to be run for RDS primary key transformer.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.