Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(api): await async event handler call in canary #2242

Merged
merged 2 commits into from
Feb 5, 2024
Merged

test(api): await async event handler call in canary #2242

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6273f25
test(api): await async event handler call in canary
sundersc Feb 5, 2024
6272082
fixed more async invocations
sundersc Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions client-test-apps/js/api-model-relationship-app/src/components/CRUDLComponents.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const createDetailComponent = <T extends any>({ deleteMutation, recordNam
? <ViewComp record={record} />
: <EditComp record={record} />
}
<Button id={`delete-${recordName}`} size='small' onClick={() => wrappedFn(context)}>Delete</Button>
<Button id={`delete-${recordName}`} size='small' onClick={async () => { await wrappedFn(context); }}>Delete</Button>
<OperationStateIndicator id={`${recordName}-is-deleted`} state={opState} />
{ detailState === 'view'
? <Button size='small' onClick={() => setDetailState('edit')}>Edit</Button>
Expand Down Expand Up @@ -67,7 +67,7 @@ export const createCreateRecordComponent = ({ recordName, createMutation, sentin
<Heading level={3}>Create A { capitalizedRecordName }</Heading>
<Flex direction='row'>
<TextField id={`${recordName}-id-input`} label='Test Id' onChange={(event: any) => { setId(event.target.value) }}/>
<Button id={`${recordName}-create`} onClick={() => wrappedFn(context)}>Create { capitalizedRecordName }</Button>
<Button id={`${recordName}-create`} onClick={async () => { await wrappedFn(context); }}>Create { capitalizedRecordName }</Button>
<OperationStateIndicator id={`${recordName}-is-created`} state={opState} />
</Flex>
</Flex>
Expand Down Expand Up @@ -102,7 +102,7 @@ export const createGetRecordComponent = <T extends any>({ getQuery, recordName,
<Heading level={3}>Get A { capitalizedRecordName }</Heading>
<Flex direction='row'>
<TextField id={`retrieve-${recordName}-id`} label={`${capitalizedRecordName} Id`} onChange={(event: any) => { setId(event.target.value) }}/>
<Button id={`retrieve-${recordName}-button`} onClick={() => wrappedFn(context)}>Get { capitalizedRecordName }</Button>
<Button id={`retrieve-${recordName}-button`} onClick={async () => { await wrappedFn(context); }}>Get { capitalizedRecordName }</Button>
<OperationStateIndicator id={`${recordName}-is-retrieved`} state={opState} />
</Flex>
<div id={`retrieved-${recordName}`}>
Expand Down Expand Up @@ -138,7 +138,7 @@ export const createListComponent = <T extends any>({ listQuery, recordName, Deta
<Flex direction='column'>
<Heading level={3}>List { capitalizedPluralizedRecordName }</Heading>
<Flex direction='row'>
<Button id={`list-${pluralizedRecordName}`} onClick={() => wrappedFn(context)}>Load { capitalizedPluralizedRecordName }</Button>
<Button id={`list-${pluralizedRecordName}`} onClick={async () => { await wrappedFn(context); }}>Load { capitalizedPluralizedRecordName }</Button>
<OperationStateIndicator id={`${pluralizedRecordName}-are-listed`} state={opState} />
</Flex>
<div id={`listed-${pluralizedRecordName}`}>
Expand Down Expand Up @@ -204,7 +204,7 @@ export const createEditComp = <T extends object>({ updateMutation, fields, recor
}}
/>
) }) }
<Button id={`update-${recordName}`} onClick={() => wrappedFn(context)}>Update</Button>
<Button id={`update-${recordName}`} onClick={async () => { await wrappedFn(context); }}>Update</Button>
<OperationStateIndicator id={`${recordName}-is-updated`} state={opState} />
</Flex>
}
Expand Down
Loading