Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use v1 transformer supported region for schema searchable test #2340

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

AaronZyLee
Copy link
Contributor

@AaronZyLee AaronZyLee commented Mar 13, 2024

Description of changes

The schema-searchable is using the v1 transformer which generates t2.small.elasticsearch instance type. The type is not available in all regions. The split e2e script is updated to assign the regions supported for v1 transformer only to this test.

CDK / CloudFormation Parameters Changed

Issue #, if available

Description of how you validated changes

The cloud e2e test is passing.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AaronZyLee AaronZyLee requested review from a team as code owners March 13, 2024 19:52
atierian
atierian previously approved these changes Mar 13, 2024
phani-srikar
phani-srikar previously approved these changes Mar 13, 2024
@AaronZyLee AaronZyLee dismissed stale reviews from phani-srikar and atierian via 6c9f6f5 March 13, 2024 21:53
@AaronZyLee AaronZyLee changed the title chore: force region for schema searchable test chore: use v1 transformer supported region for schema searchable test Mar 13, 2024
@AaronZyLee AaronZyLee merged commit 801d817 into main Mar 14, 2024
5 of 7 checks passed
@AaronZyLee AaronZyLee deleted the fix-schema-search branch March 14, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants