Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add local publish helper for release verification against amplify-backend #2517

Merged
merged 1 commit into from
May 1, 2024

Conversation

palpatim
Copy link
Member

Description of changes

New helper function to publish local workspace to local Verdaccio registry.

Description of how you validated changes

Checklist

  • PR description included

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@palpatim palpatim requested a review from a team as a code owner April 30, 2024 22:44
@@ -164,6 +164,14 @@ function _publishToLocalRegistry {

_generateChangeLog
}
function _publishLocalWorkspace {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to expose a top level script in the package.json to be able to easily run this? Like yarn publish-to-local?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went back & forth on this and landed on "not right now." I want to see it in action a few times first, and then we can make sure that a yarn task properly encompasses all the steps. For now, it's not too burdensome; involving a couple of bash invocations rather than a yarn task.

@palpatim palpatim enabled auto-merge (squash) May 1, 2024 18:53
@palpatim palpatim merged commit 5c91370 into main May 1, 2024
6 checks passed
@palpatim palpatim deleted the palpatim.chore.local-publish-flow branch May 1, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants