Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update cleanup circle contexts, remove unnecessary branches #461

Merged
merged 1 commit into from
May 18, 2022

Conversation

alharris-at
Copy link
Contributor

@alharris-at alharris-at commented May 18, 2022

Description of changes

We were using the wrong contexts for our setup job for e2e cleanup. Updating those, and removing the interim branches we were using during migration.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alharris-at alharris-at requested a review from a team May 18, 2022 19:47
@alharris-at alharris-at requested a review from a team as a code owner May 18, 2022 19:47
@codecov-commenter
Copy link

Codecov Report

Merging #461 (0bac1bd) into main (dbd2228) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   72.08%   72.08%           
=======================================
  Files         208      208           
  Lines       13471    13471           
  Branches     3200     3200           
=======================================
  Hits         9710     9710           
  Misses       3454     3454           
  Partials      307      307           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@AaronZyLee AaronZyLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the context is added in circleci. LGTM 🚢

@alharris-at alharris-at merged commit 6f187ca into main May 18, 2022
@alharris-at alharris-at deleted the circle_config_update branch May 18, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants