Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(graphql): incorrect filter expression on model transformer #697

Merged
merged 2 commits into from
Jul 26, 2022
Merged

fix(graphql): incorrect filter expression on model transformer #697

merged 2 commits into from
Jul 26, 2022

Conversation

sundersc
Copy link
Contributor

Description of changes

Validate filter expression on model transformer.

Description of how you validated changes

  • yarn test
  • manual test
  • e2e tests

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sundersc sundersc requested a review from a team as a code owner July 26, 2022 04:10
phani-srikar
phani-srikar previously approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@phani-srikar phani-srikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alharris-at
alharris-at previously approved these changes Jul 26, 2022
View reviewed changes
danielleadams
danielleadams previously approved these changes Jul 26, 2022
View reviewed changes
@danielleadams
Copy link
Contributor

@sundersc Looks like the @searchable test snapshots needs to be updated.

@sundersc sundersc merged commit a6fc3be into aws-amplify:main Jul 26, 2022
naedx pushed a commit to naedx/amplify-category-api that referenced this pull request Aug 15, 2022
@sundersc @naedx
fix(graphql): incorrect filter expression on model transformer (aws-a…
3fc5c4d 
…mplify#697)

* fix(graphql): incorrect filter expression on model transformer

* update searchable snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleadams danielleadams danielleadams approved these changes

@phani-srikar phani-srikar phani-srikar approved these changes

@alharris-at alharris-at alharris-at approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sundersc @danielleadams @phani-srikar @alharris-at