Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(graphql): add subscription tests with variable syntax #755

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

sundersc
Copy link
Contributor

Add subscription tests with variable syntax.

  • Pass owner argument with variable syntax.
  • Use variable syntax but do not pass optional argument value.

@sundersc sundersc requested a review from a team as a code owner August 22, 2022 22:46
@phani-srikar
Copy link
Contributor

I see a lot of commits unrelated to the change in this PR. Can you please update your fork with latest remote main? Thanks.

@sundersc sundersc changed the title Test subscription syntax test(graphql): add subscription tests with variable syntax Aug 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #755 (1454cec) into main (6a7b9f3) will increase coverage by 0.43%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##             main     #755      +/-   ##
==========================================
+ Coverage   63.14%   63.58%   +0.43%     
==========================================
  Files         278      279       +1     
  Lines       18125    18212      +87     
  Branches     4375     4401      +26     
==========================================
+ Hits        11445    11580     +135     
+ Misses       6093     6044      -49     
- Partials      587      588       +1     
Impacted Files Coverage Δ
...on-transformer/src/graphql-function-transformer.ts 93.54% <ø> (ø)
...l-http-transformer/src/graphql-http-transformer.ts 96.21% <ø> (ø)
...transformer/src/graphql-predictions-transformer.ts 97.80% <ø> (ø)
...-transformer/src/graphql-belongs-to-transformer.ts 97.26% <ø> (ø)
...al-transformer/src/graphql-has-many-transformer.ts 100.00% <ø> (ø)
...nal-transformer/src/graphql-has-one-transformer.ts 98.59% <ø> (ø)
...searchable-transformer/src/cdk/create-cfnOutput.ts 100.00% <ø> (ø)
...graphql-elasticsearch-transformer/src/resources.ts 100.00% <ø> (ø)
...fy-graphql-auth-transformer/src/resolvers/field.ts 71.42% <33.33%> (+2.04%) ⬆️
...l-transformer-core/src/transformation/transform.ts 16.26% <50.00%> (-0.05%) ⬇️
... and 49 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sundersc sundersc merged commit cdced31 into aws-amplify:main Aug 23, 2022
@sundersc sundersc deleted the test-subscription-syntax branch August 23, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants