Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): gateway response dropping on update api #764

Merged
merged 3 commits into from
Sep 7, 2022

Conversation

sundersc
Copy link
Contributor

@sundersc sundersc commented Aug 24, 2022

Description of changes

This PR will fix the rest api dropping gateway response on update api issue.

With this change, we will assign a new logical id to the gateway response resources on each push so it would be treated as deleting the old one and creating a new one instead of updating the existing one.

Issue #, if available

Fixes #30

Description of how you validated changes

  • manual test
  • e2e test

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sundersc sundersc requested a review from a team as a code owner August 24, 2022 23:23
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2022

Codecov Report

Merging #764 (716f04b) into main (6a7b9f3) will increase coverage by 0.34%.
The diff coverage is 91.17%.

@@            Coverage Diff             @@
##             main     #764      +/-   ##
==========================================
+ Coverage   63.14%   63.48%   +0.34%     
==========================================
  Files         278      278              
  Lines       18125    18197      +72     
  Branches     4375     4399      +24     
==========================================
+ Hits        11445    11553     +108     
+ Misses       6093     6056      -37     
- Partials      587      588       +1     
Impacted Files Coverage Δ
...plify-graphql-auth-transformer/src/utils/schema.ts 94.69% <ø> (ø)
...searchable-transformer/src/cdk/create-cfnOutput.ts 100.00% <ø> (ø)
...graphql-elasticsearch-transformer/src/resources.ts 100.00% <ø> (ø)
...fy-graphql-auth-transformer/src/resolvers/field.ts 71.42% <33.33%> (+2.04%) ⬆️
...l-transformer-core/src/transformation/transform.ts 16.26% <50.00%> (-0.05%) ⬇️
...amplify-graphql-index-transformer/src/resolvers.ts 95.92% <71.42%> (-2.86%) ⬇️
...earchable-transformer/src/generate-resolver-vtl.ts 85.00% <71.42%> (ø)
...fy-graphql-auth-transformer/src/resolvers/query.ts 90.43% <75.00%> (-0.09%) ⬇️
...-graphql-searchable-transformer/src/definitions.ts 76.00% <81.57%> (ø)
...formation/cdk-stack-builder/apigw-stack-builder.ts 63.91% <83.33%> (+2.30%) ⬆️
... and 38 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@alharris-at alharris-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit pending e2e tests

@AaronZyLee AaronZyLee merged commit 942d1d1 into aws-amplify:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Gateway DEFAULT_4XX and DEFAULT_5XX gateway response setting disappears from time to time
5 participants