chore(amplify-graphql-searchable-transformer): refactor the expression to construct aggregate values #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #784 +/- ##
=======================================
Coverage 63.39% 63.39%
=======================================
Files 278 278
Lines 18220 18222 +2
Branches 4431 4431
=======================================
+ Hits 11550 11552 +2
Misses 6074 6074
Partials 596 596
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
phani-srikar
changed the title
AaronZyLee
previously approved these changes
Sep 9, 2022
It'll be the same map object but generated dynamically i.e using the map methods. |
|
Can we run E2E against this just for sanity? |
…the expression to construct aggregate values
phani-srikar
force-pushed
the
searchable-transformer-refactors
branch
from
35d9795
to
ee2bf58
Compare
AaronZyLee
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
These changes refactor a step in the Request Mapping Template that is generated by the Searchable V2 transformer.
The step is responsible for constructing a Map that contains the Aggregate values that will eventually be used in the construction of the Search Query. The current refactor dynamically generates this Map instead of a raw JSON representation.
This is necessary for the Searchable Mocking to work since the mock VTL compiler does not read raw JSON representations.
Issue #, if available
Description of how you validated changes
The test snapshot updates show the change in the Request Mapping Template.
Added explicit checks as well.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.