Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e tests for sync expression behavior #830

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Conversation

phani-srikar
Copy link
Contributor

@phani-srikar phani-srikar commented Sep 28, 2022

Description of changes

Add e2e tests that cover this advanced use-case where a Sync query using GSI will query the base table using that GSI instead of a scan operation.

Issue #, if available

Description of how you validated changes

Successfully ran these e2e tests locally

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phani-srikar phani-srikar requested a review from a team as a code owner September 28, 2022 00:42
@codecov-commenter
Copy link

Codecov Report

Merging #830 (a47d8fc) into main (e0d7540) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #830   +/-   ##
=======================================
  Coverage   63.27%   63.27%           
=======================================
  Files         282      282           
  Lines       18356    18356           
  Branches     4453     4453           
=======================================
  Hits        11615    11615           
  Misses       6131     6131           
  Partials      610      610           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@AaronZyLee AaronZyLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just have one question on how to identify the query instead of scan from the e2e tests. Is it indicated by the timestamp?

@phani-srikar phani-srikar merged commit b3cb9ae into main Oct 5, 2022
@phani-srikar phani-srikar deleted the syncable-tests branch October 5, 2022 20:25
@phani-srikar
Copy link
Contributor Author

From my discussion with Ivan, there is no easy way to identify that unless we have logging enabled for the resolvers. However, the tests added here cover the part of the resolver that is known to generate a Query expression like using filters on GSI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants