Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding regression test for apikey+owner auth model to verify that subscriptions where owner is undefined works #838

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

alharris-at
Copy link
Contributor

@alharris-at alharris-at commented Sep 29, 2022

Description of changes

This verifies the behavior that was witnessed in these a few bugs, has not regressed. I've added an owner-auth enabled model, and verified that I can successfully subscribe and receive subscription data w/ no owner set.

Issue #, if available

#758, #134

Description of how you validated changes

Tested locally, and ran in CI - https://app.circleci.com/pipelines/github/aws-amplify/amplify-category-api/1264/workflows/e5a29202-2bc2-4c0c-af0c-c4a4e3ebd388/jobs/37099

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alharris-at alharris-at requested a review from a team as a code owner September 29, 2022 23:20
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022

Codecov Report

Merging #838 (a8d1550) into main (c0d92c7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #838   +/-   ##
=======================================
  Coverage   63.27%   63.27%           
=======================================
  Files         282      282           
  Lines       18356    18356           
  Branches     4453     4453           
=======================================
  Hits        11615    11615           
  Misses       6131     6131           
  Partials      610      610           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alharris-at alharris-at force-pushed the add-multi-auth-subscription-test branch from 11d0103 to f58a019 Compare September 30, 2022 17:12
@alharris-at alharris-at force-pushed the add-multi-auth-subscription-test branch from f58a019 to a8d1550 Compare September 30, 2022 17:15
@alharris-at alharris-at changed the title chore: adding apikey+owner auth model to verify that subscriptions where owner is undefined work chore: adding regression test for apikey+owner auth model to verify that subscriptions where owner is undefined works Sep 30, 2022
Copy link
Contributor

@sundersc sundersc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alharris-at alharris-at merged commit 3e139af into main Sep 30, 2022
@alharris-at alharris-at deleted the add-multi-auth-subscription-test branch September 30, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants