chore: add canary to run client e2e tests #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alharris-at
force-pushed
the
canary-client-tests
branch
from
c435b7d
to
1a1b259
Compare
alharris-at
changed the title
alharris-at
force-pushed
the
canary-client-tests
branch
from
1a1b259
to
08c02ba
Compare
alharris-at
force-pushed
the
canary-client-tests
branch
from
08c02ba
to
187dcb2
Compare
alharris-at
commented
Oct 4, 2022
| @@ -25,6 +28,17 @@ executors: | |||
| AMPLIFY_DIR: /home/circleci/repo/out | |||
| AMPLIFY_PATH: /home/circleci/repo/out/amplify-pkg-linux-x64 | |||
|
|
|||
| install_cli_from_local_registry: &install_cli_from_local_registry | |||
There was a problem hiding this comment.
Note: this steps is cloned over from config.base.yml
alharris-at
commented
Oct 4, 2022
| @@ -106,6 +120,73 @@ jobs: | |||
| when: always | |||
| - store_artifacts: | |||
| path: ~/repo/packages/amplify-e2e-tests/amplify-e2e-reports | |||
| publish_to_local_registry: | |||
There was a problem hiding this comment.
Note: this steps is cloned over from config.base.yml, though I've hard-coded the platform to linux, and removed the parameter as input.
alharris-at
commented
Oct 4, 2022
|
|
||
| commands: | ||
| scan_e2e_test_artifacts: |
There was a problem hiding this comment.
This was cloned over, but made to only operate on linux as a simplifier, same w/ the run_client_tests command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
add canary to run client e2e tests, these can be triggered either by the schedule (4 times daily), or kicked off manually by setting the
canaryparameter.N.B. To support running both scheduled and from a manual kickoff I've had to redeclare the workflow in both
config.ymlandconfig.base.yml, and duplicate a few workflow steps and commands intoconfig.yml. I'd rather have this duplication and the ability to trigger manual canary runs, at the cost of possible divergence.Publishing metrics to CW will come as a separate PR.
Issue #, if available
N/A
Description of how you validated changes
Verified the manual job in CCI, but still need to verify the scheduling. Because the job is running against main for scheduling, it's not finding the config on that branch, so I'll need to verify once this is merged. I have manually run a canary workflow here https://app.circleci.com/pipelines/github/aws-amplify/amplify-category-api/1320/workflows/d1b3cba7-b950-4cde-b2ea-937c52429312
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.