Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split containers-api tests #946

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Nov 2, 2022

Description of changes

This splits two long running tests in order to:

  • decrease total load
  • increase stability and retryability (they both running in same job compounds chance of failed attempt)

FWIW this has been split in CLI repo for the same reason
See https://github.com/aws-amplify/amplify-cli/blob/dev/packages/amplify-e2e-tests/src/__tests__/containers-api-1.test.ts
and https://github.com/aws-amplify/amplify-cli/blob/dev/packages/amplify-e2e-tests/src/__tests__/containers-api-2.test.ts

Issue #, if available

Description of how you validated changes

E2E tests run https://app.circleci.com/pipelines/github/aws-amplify/amplify-category-api/1940/workflows/77347e4a-bf0e-4441-83c0-928d111f7fe3

Checklist

  • [ x] PR description included
  • [ x] yarn test passes
  • [ x] Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alharris-at
Copy link
Contributor

Approving, pending those two split e2e's passing

@alharris-at alharris-at merged commit 7387dcb into main Nov 2, 2022
@alharris-at alharris-at deleted the split-container-api-tests branch November 2, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants