Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(graphql): protect relational fields when fields rules are restrictive #950

Merged
merged 3 commits into from
Nov 3, 2022
Merged

fix(graphql): protect relational fields when fields rules are restrictive #950

merged 3 commits into from
Nov 3, 2022

Conversation

sundersc
Copy link
Contributor

@sundersc sundersc commented Nov 3, 2022

Description of changes

Protect relational fields when field rules are more restrictive than the model auth rules.

Issue #, if available

NA.

Description of how you validated changes

  • manual testing
  • added new e2e tests

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sundersc sundersc requested a review from a team as a code owner November 3, 2022 18:32
@sundersc sundersc marked this pull request as draft November 3, 2022 18:34
@sundersc sundersc marked this pull request as ready for review November 3, 2022 18:44
lazpavel
lazpavel approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@lazpavel lazpavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sundersc sundersc merged commit a120378 into aws-amplify:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazpavel lazpavel lazpavel approved these changes

@alharris-at alharris-at alharris-at approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sundersc @lazpavel @alharris-at