fix(amplify-category-auth): removes deprecated props for external auth (

#2587) fix(#2309) deprecated params are also reflected in the template
aws-amplify · Oct 18, 2019 · 08c0c70 · 08c0c70
1 parent c8ae475
commit 08c0c70
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/amplify-category-auth/index.js b/packages/amplify-category-auth/index.js
@@ -12,6 +12,7 @@ const {
   saveResourceParameters,
   ENV_SPECIFIC_PARAMS,
   migrate,
+  removeDeprecatedProps,
 } = require('./provider-utils/awscloudformation');
 
 // this function is being kept for temporary compatability.
@@ -110,12 +111,13 @@ async function externalAuthEnable(context, externalCategory, resourceName, requi
       }); //eslint-disable-line
   /* eslint-enable */
   const { roles } = defaults;
-  const authProps = {
+  let authProps = {
     ...authPropsValues,
     ...roles,
   };
 
   try {
+    authProps = removeDeprecatedProps(authProps);
     await copyCfnTemplate(context, category, authProps, cfnFilename);
     saveResourceParameters(context, provider, category, authProps.resourceName, authProps, ENV_SPECIFIC_PARAMS);
     if (!authExists) {

diff --git a/packages/amplify-category-auth/provider-utils/awscloudformation/index.js b/packages/amplify-category-auth/provider-utils/awscloudformation/index.js
@@ -575,7 +575,7 @@ function removeDeprecatedProps(props) {
   if (props.openIdRolePolicy) {
     delete props.openIdRolePolicy;
   }
-  if (props.openIdRopenIdLambdaIAMPolicyolePolicy) {
+  if (props.openIdLambdaIAMPolicy) {
     delete props.openIdLambdaIAMPolicy;
   }
   if (props.openIdLogPolicy) {
@@ -617,4 +617,5 @@ module.exports = {
   migrate,
   console,
   getPermissionPolicies,
+  removeDeprecatedProps,
 };