Skip to content

Commit

Permalink
fix: remove async map generic dataschema
Browse files Browse the repository at this point in the history
  • Loading branch information
Justin Shih committed Sep 27, 2023
1 parent f79a767 commit 4d76058
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ const getUiBuilderComponentsPathMocked = getUiBuilderComponentsPath as any;
utilsMock.shouldRenderComponents = jest.fn().mockReturnValue(true);
utilsMock.notifyMissingPackages = jest.fn().mockReturnValue(true);
utilsMock.getAmplifyDataSchema = jest.fn().mockReturnValue({});
utilsMock.mapGenericDataSchemaToCodegen = jest.fn().mockReturnValue({});
utilsMock.isFormDetachedFromModel = jest.fn().mockReturnValue(false);
utilsMock.extractUIComponents = jest.fn().mockReturnValue(undefined);
utilsMock.waitForSucceededJob = jest
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const run = async (context: $TSContext, eventType: 'PostPush' | 'PostPull
studioClient.isGraphQLSupported ? getAmplifyDataSchema(context) : Promise.resolve(undefined),
]);
const genericDataSchema = dataSchema ? mapGenericDataSchemaToCodegen(dataSchema) : undefined;

const canGenerateDataComponents = genericDataSchema && studioClient.isGraphQLSupported;

const apiConfiguration: AmplifyUIBuilder.ApiConfiguration = canGenerateDataComponents
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ const mapDataFieldsToCodegen = (fields: { [fieldName: string]: GenericDataField
return codegenFields;
};

export const mapGenericDataSchemaToCodegen = async (genericDataSchema: GenericDataSchema): CodegenJobGenericDataSchema | undefined => {
export const mapGenericDataSchemaToCodegen = (genericDataSchema: GenericDataSchema): CodegenJobGenericDataSchema => {
const { models, nonModels, enums, dataSourceType } = genericDataSchema;
const codegenModels: { [key: string]: CodegenGenericDataModel } = {};
const codegenNonModels: { [key: string]: CodegenGenericDataNonModel } = {};
Expand Down
23 changes: 12 additions & 11 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1043,6 +1043,17 @@ __metadata:
languageName: node
linkType: hard

"@aws-amplify/api@npm:5.4.5":
version: 5.4.5
resolution: "@aws-amplify/api@npm:5.4.5"
dependencies:
"@aws-amplify/api-graphql": 3.4.11
"@aws-amplify/api-rest": 3.5.5
tslib: ^1.8.0
checksum: 13f3551e5d2d29a201f5011a265fcaa24fdec4796afe835f2c0d9b8fcc76f243663d691de2273c680b2efbe4fea2fb1ecd7678ed393a605997ee97021f03d138
languageName: node
linkType: hard

"@aws-amplify/appsync-modelgen-plugin@npm:2.7.2, @aws-amplify/appsync-modelgen-plugin@npm:^2.6.0":
version: 2.7.2
resolution: "@aws-amplify/appsync-modelgen-plugin@npm:2.7.2"
Expand Down Expand Up @@ -12824,7 +12835,7 @@ __metadata:
languageName: node
linkType: hard

"@types/node-fetch@npm:2.6.4":
"@types/node-fetch@npm:2.6.4, @types/node-fetch@npm:^2.6.1":
version: 2.6.4
resolution: "@types/node-fetch@npm:2.6.4"
dependencies:
Expand All @@ -12834,16 +12845,6 @@ __metadata:
languageName: node
linkType: hard

"@types/node-fetch@npm:^2.6.1":
version: 2.6.1
resolution: "@types/node-fetch@npm:2.6.1"
dependencies:
"@types/node": "*"
form-data: ^3.0.0
checksum: 033945215fa6b36d5597b21bbdd7d946a751dcd066f8fa71e5f5ab5698390bc2e76e38932ec6ac709def39b6371dfd61844e6804409c7ba812e24d1c820fbff8
languageName: node
linkType: hard

"@types/node@npm:*, @types/node@npm:^18.16.1":
version: 18.16.1
resolution: "@types/node@npm:18.16.1"
Expand Down

0 comments on commit 4d76058

Please sign in to comment.