fix: avoid empty and string rejects (#12818)

aws-amplify · Jun 16, 2023 · 911faa7 · 911faa7
1 parent 84cad9e
commit 911faa7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/amplify-console-hosting/src/utils/amplify-console-utils.js b/packages/amplify-console-hosting/src/utils/amplify-console-utils.js
@@ -55,7 +55,7 @@ function waitJobToSucceed(job, amplifyClient) {
   return new Promise(async (resolve, reject) => {
     const timeout = setTimeout(() => {
       console.log('Job Timeout before succeeded');
-      reject();
+      reject(new Error('Job Timeout before succeeded'));
     }, 1000 * 60 * 10);
     let processing = true;
     try {

diff --git a/packages/amplify-console-hosting/src/utils/build-utils.js b/packages/amplify-console-hosting/src/utils/build-utils.js
@@ -9,7 +9,7 @@ const DIR_NOT_FOUND_ERROR_MESSAGE = 'Please ensure your build artifacts path exi
 function zipFile(sourceDir, destFilePath, extraFiles) {
   return new Promise((resolve, reject) => {
     if (!fs.pathExistsSync(sourceDir)) {
-      reject(DIR_NOT_FOUND_ERROR_MESSAGE);
+      reject(new Error(DIR_NOT_FOUND_ERROR_MESSAGE));
     }
     const zipFilePath = destFilePath;
     const output = fs.createWriteStream(zipFilePath);

diff --git a/packages/amplify-provider-awscloudformation/src/admin-login.ts b/packages/amplify-provider-awscloudformation/src/admin-login.ts
@@ -61,7 +61,7 @@ export const adminLoginFlow = async (context: $TSContext, appId: string, envName
           }
           finished = true;
           adminLoginServer.shutdown();
-          reject();
+          resolve();
         };
       });
 
@@ -116,7 +116,7 @@ export const adminLoginFlow = async (context: $TSContext, appId: string, envName
           }
           finished = true;
           closeReadline(rl);
-          reject();
+          resolve();
         };
       });
       return [promise, cancel];