fix: version bucket conditional (#6131)

* fix: version bucket conditional * fix: remove unused versioned bucket and lifecycle policy
aws-amplify · Dec 9, 2020 · 9c4281f · 9c4281f
1 parent 89c9d8b
commit 9c4281f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 13 deletions.
diff --git a/packages/amplify-provider-awscloudformation/resources/rootStackTemplate.json b/packages/amplify-provider-awscloudformation/resources/rootStackTemplate.json
@@ -23,19 +23,6 @@
       "Properties": {
         "BucketName": {
           "Ref": "DeploymentBucketName"
-        },
-        "VersioningConfiguration": {
-          "Status": "Enabled"
-        },
-        "LifecycleConfiguration": {
-          "Rules": [
-            {
-              "ExpirationInDays": 7,
-              "NoncurrentVersionExpirationInDays": 7,
-              "Prefix": "codepipeline-amplify/",
-              "Status": "Enabled"
-            }
-          ]
         }
       }
     },

diff --git a/packages/amplify-provider-awscloudformation/src/push-resources.ts b/packages/amplify-provider-awscloudformation/src/push-resources.ts
@@ -757,6 +757,21 @@ async function formNestedStack(
         TemplateURL: NetworkStackS3Url,
       },
     };
+
+    nestedStack.Resources.DeploymentBucket.Properties['VersioningConfiguration'] = {
+      "Status": "Enabled"
+    };
+
+    nestedStack.Resources.DeploymentBucket.Properties['LifecycleConfiguration'] = {
+      "Rules": [
+        {
+          "ExpirationInDays": 7,
+          "NoncurrentVersionExpirationInDays": 7,
+          "Prefix": "codepipeline-amplify/",
+          "Status": "Enabled"
+        }
+      ]
+    };
   }
 
   let categories = Object.keys(amplifyMeta);