fix(cli): spinner hiding prompt (#9875)

aws-amplify · Mar 9, 2022 · c7e7b90 · c7e7b90
1 parent 1779fa0
commit c7e7b90
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 3 deletions.
diff --git a/packages/amplify-cli-core/package.json b/packages/amplify-cli-core/package.json
@@ -39,6 +39,7 @@
     "lodash": "^4.17.21",
     "node-fetch": "^2.6.7",
     "open": "^8.4.0",
+    "ora": "^4.0.3",
     "proxy-agent": "^5.0.0",
     "semver": "^7.3.5",
     "typescript-json-schema": "~0.52.0",

diff --git a/packages/amplify-cli-core/src/index.ts b/packages/amplify-cli-core/src/index.ts
@@ -31,6 +31,7 @@ export * from './category-interfaces';
 export * from './customPoliciesUtils';
 export * from './utils/doc-links';
 export * from './utils/gql-transformer-version';
+export * from './spinner';
 
 // Temporary types until we can finish full type definition across the whole CLI
 

diff --git a/packages/amplify-cli-core/src/spinner/index.ts b/packages/amplify-cli-core/src/spinner/index.ts
@@ -0,0 +1,3 @@
+import ora, { Ora } from 'ora';
+
+export const spinner : Ora = new (ora as any)();
diff --git a/packages/amplify-provider-awscloudformation/src/export-resources.ts b/packages/amplify-provider-awscloudformation/src/export-resources.ts
@@ -1,10 +1,9 @@
-import { $TSAny, $TSContext, JSONUtilities, PathConstants, stateManager } from 'amplify-cli-core';
+import { $TSAny, $TSContext, JSONUtilities, PathConstants, stateManager, spinner } from 'amplify-cli-core';
 import { ResourceExport } from './resource-package/resource-export';
 import { ResourceDefinition, StackIncludeDetails, StackParameters } from './resource-package/types';
 import * as path from 'path';
 import { printer, prompter } from 'amplify-prompts';
 import * as fs from 'fs-extra';
-import Ora from 'ora';
 const backup = 'backup';
 import _ from 'lodash';
 import rimraf from 'rimraf';
@@ -31,7 +30,6 @@ export async function run(context: $TSContext, resourceDefinition: $TSAny[], exp
     return;
   }
 
-  const spinner = Ora('Exporting...');
   spinner.start();
   try {
     const resourceExport = new ResourceExport(context, amplifyExportFolder);

diff --git a/packages/amplify-provider-awscloudformation/src/resource-package/resource-packager.ts b/packages/amplify-provider-awscloudformation/src/resource-package/resource-packager.ts
@@ -7,6 +7,7 @@ import {
   readCFNTemplate,
   stateManager,
   writeCFNTemplate,
+  spinner,
 } from 'amplify-cli-core';
 import _ from 'lodash';
 import { legacyLayerMigration, prePushLambdaLayerPrompt } from '../lambdaLayerInvocations';
@@ -106,7 +107,9 @@ export abstract class ResourcePackager {
     )) {
       await legacyLayerMigration(this.context, lambdaLayerResource.resourceName);
     }
+    spinner.stop();
     await prePushLambdaLayerPrompt(this.context, resources);
+    spinner.start();
     return resources;
   }