Use prompter and handle deletions #10122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnpc
force-pushed
the
run-e2e/xss/use-prompter
branch
from
16bea31
to
d1933fc
Compare
edwardfoyle
reviewed
Apr 4, 2022
packages/amplify-cli/src/extensions/amplify-helpers/trigger-flow.ts
Outdated
Show resolved
Hide resolved
|
This pull request introduces 1 alert when merging d1933fc into f634754 - view on LGTM.com new alerts:
|
ammarkarachi
reviewed
Apr 4, 2022
| @@ -1,5 +1,5 @@ | |||
| import { $TSContext, $TSObject, exitOnNextTick, ResourceCredentialsNotFoundError, ResourceDoesNotExistError } from 'amplify-cli-core'; | |||
| import { printer } from 'amplify-prompts'; | |||
| import { printer, prompter } from 'amplify-prompts'; | |||
| import chalk from 'chalk'; | |||
| import { DataApiParams } from 'graphql-relational-schema-transformer'; | |||
| import inquirer from 'inquirer'; | |||
There was a problem hiding this comment.
Do you still need this in the file?
|
LGTM just some unused |
ammarkarachi
approved these changes
Apr 4, 2022
johnpc
force-pushed
the
run-e2e/xss/use-prompter
branch
from
d1933fc
to
06d3285
Compare
johnpc
force-pushed
the
run-e2e/xss/use-prompter
branch
from
06d3285
to
14ecc43
Compare
edwardfoyle
approved these changes
Apr 4, 2022
johnpc
added a commit
that referenced
this pull request
Apr 5, 2022
this commit uses prompter and handles deletions. This commit message should trigger a new major version of @aws-amplify/cli BREAKING CHANGE: package name update requires version bump in order to keep in sync with lerna.
johnpc
added a commit
that referenced
this pull request
Apr 5, 2022
this commit uses prompter and handles deletions. This commit message should trigger a new major version of @aws-amplify/cli BREAKING CHANGE: package name update requires version bump in order to keep in sync with lerna.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR makes a couple small changes:
amplify-prompterin areas where we've noticed timeouts caused by unexpected prompts when the--yesflag is setIssue #, if available
n/a
Description of how you validated changes
--yesflagChecklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.