Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "refactor: plugin platform code cleanup" #10403

Merged
merged 1 commit into from May 12, 2022

Conversation

jhockett
Copy link
Contributor

@jhockett jhockett requested a review from a team as a code owner May 11, 2022 22:24
@alharris-at
Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

Merging #10403 (92292b5) into master (2612585) will decrease coverage by 0.00%.
The diff coverage is 59.52%.

@@            Coverage Diff             @@
##           master   #10403      +/-   ##
==========================================
- Coverage   46.57%   46.57%   -0.01%     
==========================================
  Files         703      703              
  Lines       35245    35254       +9     
  Branches     7136     7137       +1     
==========================================
+ Hits        16417    16418       +1     
- Misses      17043    17049       +6     
- Partials     1785     1787       +2     
Impacted Files Coverage Δ
...ify-cli/src/plugin-helpers/scan-plugin-platform.ts 17.85% <34.21%> (-3.25%) ⬇️
packages/amplify-cli/src/plugin-manager.ts 17.39% <67.85%> (-0.26%) ⬇️
...es/amplify-cli/src/plugin-helpers/verify-plugin.ts 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jhockett jhockett merged commit b2998d7 into master May 12, 2022
@jhockett jhockett deleted the revert-10384-plugin-scan-refactor branch May 12, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants