Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: plugin platform code cleanup #10384

Merged
merged 1 commit into from May 11, 2022

Conversation

jhockett
Copy link
Contributor

@jhockett jhockett commented May 9, 2022

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jhockett jhockett requested a review from a team as a code owner May 9, 2022 19:59
@codecov-commenter
Copy link

Codecov Report

Merging #10384 (3e88cf5) into master (714f2fa) will increase coverage by 0.01%.
The diff coverage is 64.86%.

@@            Coverage Diff             @@
##           master   #10384      +/-   ##
==========================================
+ Coverage   46.57%   46.59%   +0.01%     
==========================================
  Files         703      703              
  Lines       35246    35237       -9     
  Branches     7134     7133       -1     
==========================================
  Hits        16417    16417              
+ Misses      17042    17035       -7     
+ Partials     1787     1785       -2     
Impacted Files Coverage Δ
...ify-cli/src/plugin-helpers/scan-plugin-platform.ts 21.10% <45.71%> (+3.24%) ⬆️
packages/amplify-cli/src/plugin-manager.ts 17.64% <72.00%> (+0.25%) ⬆️
...es/amplify-cli/src/plugin-helpers/verify-plugin.ts 100.00% <100.00%> (ø)
...li/src/domain/amplify-usageData/getUsageDataUrl.ts 100.00% <0.00%> (+12.50%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@sachscode sachscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhockett jhockett merged commit 7474ba6 into aws-amplify:master May 11, 2022
@jhockett jhockett deleted the plugin-scan-refactor branch May 11, 2022 19:33
jhockett added a commit that referenced this pull request May 11, 2022
alharris-at added a commit that referenced this pull request May 11, 2022
jhockett added a commit that referenced this pull request May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants