feat: migrates notifications category to support in app messaging channel notifications #11170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: in app messaging initial commit
… in-app-messaging
|
This pull request introduces 1 alert when merging 4f7f82b into 9ecc3f4 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 45bd7bb into 9ecc3f4 - view on LGTM.com new alerts:
|
lazpavel
commented
Oct 14, 2022
...-analytics/src/provider-utils/awscloudformation/service-walkthroughs/pinpoint-walkthrough.ts
Show resolved
Hide resolved
lazpavel
commented
Oct 14, 2022
...-analytics/src/provider-utils/awscloudformation/service-walkthroughs/pinpoint-walkthrough.ts
Show resolved
Hide resolved
akshbhu
reviewed
Oct 14, 2022
packages/amplify-category-analytics/src/migrations/in-app-messaging-migration.ts
Show resolved
Hide resolved
akshbhu
previously approved these changes
Oct 14, 2022
packages/amplify-category-analytics/src/migrations/in-app-messaging-migration.ts
Outdated
Show resolved
Hide resolved
...-analytics/src/provider-utils/awscloudformation/service-walkthroughs/pinpoint-walkthrough.ts
Outdated
Show resolved
Hide resolved
edwardfoyle
reviewed
Oct 14, 2022
packages/amplify-category-analytics/src/migrations/in-app-messaging-migration.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-analytics/src/migrations/in-app-messaging-migration.ts
Outdated
Show resolved
Hide resolved
...-analytics/src/provider-utils/awscloudformation/service-walkthroughs/pinpoint-walkthrough.ts
Outdated
Show resolved
Hide resolved
...-analytics/src/provider-utils/awscloudformation/service-walkthroughs/pinpoint-walkthrough.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-analytics/src/utils/pinpoint-helper.ts
Outdated
Show resolved
Hide resolved
sobolk
reviewed
Oct 14, 2022
packages/amplify-category-analytics/src/migrations/in-app-messaging-migration.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-analytics/src/utils/pinpoint-helper.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-analytics/src/utils/pinpoint-helper.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-analytics/src/migrations/in-app-messaging-migration.ts
Outdated
Show resolved
Hide resolved
jhockett
reviewed
Oct 14, 2022
packages/amplify-category-analytics/src/migrations/in-app-messaging-migration.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-analytics/src/migrations/in-app-messaging-migration.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-analytics/src/migrations/in-app-messaging-migration.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-analytics/src/utils/pinpoint-helper.ts
Outdated
Show resolved
Hide resolved
sobolk
previously approved these changes
Oct 14, 2022
Comment on lines
10
to
13
| /** | ||
| * | ||
| */ | ||
| export type PinpointApp = { |
There was a problem hiding this comment.
For future discussions.
we should tweak eslint to enforce docs only on types that we export outside of single package.
enforcing docs for internals isn't very productive.
There was a problem hiding this comment.
I actually missed it, it was added on save, but will leave it for now to not dismiss the approval, unless the recent changes broke something and will need tweaked
jhockett
reviewed
Oct 14, 2022
packages/amplify-category-analytics/src/migrations/in-app-messaging-migration.ts
Outdated
Show resolved
Hide resolved
…aging-migration.ts Co-authored-by: John Hockett <jhockett@users.noreply.github.com>
jhockett
previously approved these changes
Oct 14, 2022
sobolk
previously approved these changes
Oct 15, 2022
awsluja
pushed a commit
that referenced
this pull request
Oct 17, 2022
…nnel notifications (#11170) * feat: migrates notifications category to support in app messaging channel notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #11087
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.