-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pull project with removed notifications #11378
Conversation
Hi team, I found an issue on amplify cli 10.4.0 which may be related.
The error message is "Cannot set property 'Id' of undefined", and if ignore this err and run "amplify push", although command push successfully, the error is in prod "no categorize enabled" Thanks |
@yanlin96 - do you mind opening a GitHub Issue for what you are seeing? (https://github.com/aws-amplify/amplify-cli/issues/new/choose) Thanks! |
packages/amplify-migration-tests/src/migration-helpers/notifications-helpers.ts
Outdated
Show resolved
Hide resolved
import { addLegacySmsNotificationChannel, removeLegacyAllNotificationChannel } from '../../../migration-helpers/notifications-helpers'; | ||
import { getShortId } from '../../../migration-helpers/utils'; | ||
|
||
describe('amplify add notifications', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏼
Hi team, The new issue opened - #11432 |
This pull request introduces 1 alert when merging e370a52 into 163ab8f - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
* fix: pull project with removed notifications
* fix: pull project with removed notifications
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.