-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add resource parameter map to backend-config.json
#11417
Conversation
backend-config.json
This pull request fixes 1 alert when merging 024922d into 5ebbc72 - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
packages/amplify-environment-parameters/src/backend-config-parameters-controller.ts
Outdated
Show resolved
Hide resolved
packages/amplify-environment-parameters/src/environment-parameter-manager.ts
Outdated
Show resolved
Hide resolved
packages/amplify-environment-parameters/src/resource-parameter-manager.ts
Outdated
Show resolved
Hide resolved
packages/amplify-environment-parameters/src/resource-parameter-manager.ts
Outdated
Show resolved
Hide resolved
This pull request fixes 1 alert when merging 613a3dc into 1dc42ba - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
This pull request fixes 1 alert when merging def0462 into e9fb32f - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
@edwardfoyle you have some merge conflicts. |
This pull request fixes 1 alert when merging 4ac718e into b5a8783 - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
This pull request fixes 1 alert when merging 1be51ed into 7d17da9 - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
Description of changes
Places a map of parameter names and which resources they relate to in the
backend-config.json
file. There are a few oddities with how this had to be implemented:backend-config.json
file is used as a list of categories (such as inamplify status
) so I modifiedstateManager.getBackendConfig
to only return the parameters key if a special flag is specified. This flag is only used by the new parameter map manager class.backend-config.json
to disk is not stable -- the same object may be serialized with keys in different order depending on how the object was constructed. A new flag has been added to JSONUtilities.stringify to specify that object keys should be sorted to ensure deterministic serializationIssue #, if available
Description of how you validated changes
Added unit tests and existing e2e tests pass
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.