Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend-config.json has env specific stack name for notifications #1372

Closed
et304383 opened this issue Apr 30, 2019 · 1 comment · Fixed by #1440
Closed

backend-config.json has env specific stack name for notifications #1372

et304383 opened this issue Apr 30, 2019 · 1 comment · Fixed by #1440
Assignees
@UnleashedMind
Labels
bug Something isn't working notifications Issues tied to the notifications category

Comments

@et304383
Copy link

Describe the bug
Notifications section of backend-config.json is being named with env instead of this dynamically happening during deploy.

Eg:

Checkout dev:

    "notifications": {
        "amplifyreactappdemoudAOX-dev": {
            "service": "Pinpoint",
            "channels": []
        }
    }

Checkout test:

    "notifications": {
        "amplifyreactappdemobrrHH-test": {
            "service": "Pinpoint",
            "channels": []
        }
    }

It's also changing some random string there too. The rest of the file doesn't change when switching between environments. This obviously is an issue given this file is managed under source control and shouldn't change just because we switch between environments.
@et304383 et304383 changed the title backend-config.json notifications has env specific stack name for notifications backend-config.json has env specific stack name for notifications Apr 30, 2019
@yuth yuth added notifications Issues tied to the notifications category pending-triage Issue is pending triage labels Apr 30, 2019
@kaustavghosh06 kaustavghosh06 added bug Something isn't working and removed pending-triage Issue is pending triage labels May 3, 2019
UnleashedMind added a commit to UnleashedMind/amplify-cli that referenced this issue May 11, 2019
@UnleashedMind
fix(amplify-category-notifications): remove env name
d2a3d65 
remove env name from the resource name in the notification category

fix aws-amplify#1372
@UnleashedMind UnleashedMind mentioned this issue May 11, 2019
Merged
@ghost ghost added the review label May 11, 2019
UnleashedMind added a commit that referenced this issue Jun 10, 2019
@UnleashedMind
fix(amplify-category-notifications): remove env name (#1440)
19ff63c 
* fix(amplify-category-notifications): remove env name

remove env name from the resource name in the notification category

fix #1372

* update
@github-actions
Copy link

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@UnleashedMind UnleashedMind

Labels
bug Something isn't working notifications Issues tied to the notifications category
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(amplify-category-notifications): remove env name UnleashedMind/amplify-cli
4 participants
@yuth @et304383 @UnleashedMind @kaustavghosh06