-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(amplify-category-notifications): remove env name #1440
fix(amplify-category-notifications): remove env name #1440
Conversation
remove env name from the resource name in the notification category fix aws-amplify#1372
@@ -25,7 +21,6 @@ module.exports = { | |||
console, | |||
deletePinpointAppForEnv, | |||
initEnv, | |||
initEnvPush, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this removed? I beleive this would break a few things including migration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that was an unneeded leftover from last year, we were talking about possibly separating initEnv locally and then push, but that's not the workflow we used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment above ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
remove env name from the resource name in the notification category
in both the amplify-meta.json file and the backend-config.json file
projects configured by the previous versions will be automatically handled without customers' efforts.
fix #1372
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.