feat(cli): cLI updates and new features for Amplify Console #2742

UnleashedMind · 2019-11-14T19:58:29Z

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

lgtm-com · 2019-11-14T20:07:50Z

This pull request introduces 1 alert when merging 62fa864 into fe0e979 - view on LGTM.com

new alerts:

1 for Assignment to constant

lgtm-com · 2019-11-15T00:33:19Z

This pull request introduces 2 alerts when merging df87b2d into fe0e979 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

lgtm-com · 2019-11-15T02:59:54Z

This pull request introduces 2 alerts when merging 1069ea0 into fe0e979 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

lgtm-com · 2019-11-15T20:14:09Z

This pull request introduces 3 alerts when merging 478ccc6 into fe0e979 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class
1 for Property access on null or undefined

lgtm-com · 2019-11-15T21:49:43Z

This pull request introduces 2 alerts when merging fc8b1a8 into 0cd2e90 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

lgtm-com · 2019-11-15T23:52:36Z

This pull request introduces 2 alerts when merging 3ce6695 into 7155787 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

ammarkarachi · 2019-11-20T02:16:54Z

packages/amplify-cli/src/lib/input-params-manager.js

@@ -26,10 +26,12 @@ function normalizeKey(key) {
 }

 function normalizeValue(key, value) {
-  if (key === 'app') {
-    return value;
+  let normalizedValue = value;


Instead of mutating a variable I suggest we could do this

try { return JSON.parse(value); } catch (e) { // do nothing } return value;

We can't do it.
Basically what this function does is that, if the import string can be parsed as JSON, it will parse it, else it will return as is.

ammarkarachi · 2019-11-20T02:43:02Z

packages/amplify-cli/src/lib/attach-backend-steps/a20-analyzeProject.js

+  const projectPath = process.cwd();
+  const localEnvFilePath = context.amplify.pathManager.getLocalEnvFilePath(projectPath);
+  if (fs.existsSync(localEnvFilePath)) {
+    ({ defaultEditor } = readJsonFile(localEnvFilePath));


return readJsonFile(localEnvFilePath).defaultEditor without creating and assigning

attilah

Added comments, mostly about duplicated code.

attilah · 2019-11-20T04:28:05Z

packages/amplify-cli/src/commands/console.js

+
+function constructStatusURL(appId, envName) {
+  const prodURL = `https://console.aws.amazon.com/amplify/home#/${appId}/YmFja2VuZA/${envName}`; // eslint-disable-line
+  const betaURL = `https://aws-mobile-apphub-beta.corp.amazon.com/amplify/home#/${appId}/YmFja2VuZA/${envName}`;


beta URLs should be removed.

was only used for Console's beta testing, removed.

attilah · 2019-11-20T04:29:53Z

packages/amplify-cli/src/commands/pull.js

+module.exports = {
+  name: 'pull',
+  run: async context => {
+    const currentAmplifyMetaFilePath = context.amplify.pathManager.getCurrentAmplifyMetaFilePath(process.cwd());


It would be nice to have the cwd in the context as currentDirectory and use it from downstream code and not to reach out to process.

I don't see issue with using process.cwd() though, and it's very straightforward.

attilah · 2019-11-20T04:34:17Z

packages/amplify-cli/src/extensions/amplify-helpers/update-backend-config.js

@@ -35,7 +44,11 @@ function updateBackendConfigDependsOn(category, resourceName, attribute, value)

 function updateBackendConfigAfterResourceRemove(category, resourceName) {
  const backendConfigFilePath = pathManager.getBackendConfigFilePath();


Shouldn't we extract this common code that operates on backendConfig and reuse it instead of having copies of it?

Agree, done.

attilah · 2019-11-20T04:35:51Z

packages/amplify-cli/src/lib/amplify-service-helper.js

+  const inputParams = normalizeInputParams(context);
+
+  if (inputParams.appId) {
+    inputParams.amplify.appId = inputParams.appId;


inputParams.amplify always defined?

The repeated code could be simplified:

const moveProperty = (name) => { if (inputParams[name]) { inputParams.amplify[name] = inputParams[name]; delete inputParams[name]; } }; const properties = ['appId', 'envName', 'no-override'] for (const property of properties) { moveProperty(property); }

yes, inputParams.amplify always exists, see the above comment.

We only allow the "outside" amplify parameter for 'appId', 'envName' and 'no-override', others can not just be added under "amplify".

attilah · 2019-11-20T05:00:37Z

packages/amplify-cli/src/lib/attach-backend.js

+    const confirmKeepCodebase = await context.amplify.confirmPrompt.run('Do you want to keep the backend codebase?', true);
+    if (confirmKeepCodebase) {
+      context.print.info('');
+      context.print.success('Backend environment has been successfully pulled and attached to your project.');


wording: what do you think about "the" instead of "your"?

The suggested wording has not been implemented: "✔ Successfully pulled backend environment '$envname' from the cloud."

attilah · 2019-11-20T05:24:30Z

packages/amplify-provider-awscloudformation/lib/attach-backend.js

+      return backendEnvs[0];
+    }
+  } else {
+    const errorMessage = `Found no currently existing backend environment in the amplify project: ${amplifyApp.name}.`;


Same as above

wording is decided by the PM.

Cannot find backend environment ${inputEnvName} in Amplify Console app: ${amplifyApp.name}

in this workflow, the use does not have inputEnvName
I changed it to:
Cannot find any backend environments in the Amplify project ${amplifyApp.name}.;
Let me know if you want to change again.

attilah · 2019-11-20T05:27:21Z

packages/amplify-provider-awscloudformation/lib/attach-backend.js

+  fs.removeSync(tempDirPath);
+}
+
+async function getAwsConfig(context) {


We already have this function, can't we reuse it?

yes.
Moved the method to the configuration manager, and reuse it in both init and attach-backend.

attilah · 2019-11-20T05:35:03Z

packages/amplify-provider-awscloudformation/src/aws-utils/aws-amplify.js

+const proxyAgent = require('proxy-agent');
+const configurationManager = require('../../lib/configuration-manager');
+
+// const betaEndpoint = 'https://ntb76nklh1.execute-api.us-west-2.amazonaws.com/beta';


These should be removed

attilah · 2019-11-20T05:36:20Z

packages/amplify-provider-awscloudformation/package.json

@@ -11,7 +11,7 @@
    "amplify-category-storage": "1.31.0",
    "amplify-codegen": "1.29.0",
    "archiver": "^2.1.1",
-    "aws-sdk": "^2.510.0",
+    "aws-sdk": "file:../../aws-sdk/",


We should remove this once the SDK is published

attilah · 2019-11-20T05:37:39Z

yarn.lock

@@ -3995,6 +3995,19 @@ aws-sdk@^2.510.0:
    uuid "3.3.2"
    xml2js "0.4.19"

+"aws-sdk@file:aws-sdk":


After SDK publish yarn.lock should be refreshed.

yuth · 2019-11-19T02:18:07Z

.gitignore

@@ -22,3 +22,4 @@ packages/*/package-lock.json
 amplify-integ*/
 packages/amplify-storage-simulator/lib
 packages/**/reports/junit/*
+aws-sdk/


Do we need this?

was only for Console team's beta testing, removed.

packages/amplify-cli/src/commands/push.js

yuth · 2019-11-20T16:00:34Z

packages/amplify-cli/src/lib/attach-backend-steps/a10-queryProvider.js

+async function getProvider(context, providerPlugins) {
+  let result;
+  const providers = [];
+  const providerPluginList = Object.keys(providerPlugins);
+  const { inputParams } = context.exeInfo;
+  if (inputParams && inputParams.amplify && inputParams.amplify.providers) {
+    inputParams.amplify.providers.forEach(provider => {
+      provider = normalizeProviderName(provider, providerPluginList);
+      if (provider) {
+        providers.push(provider);
+      }
+    });
+  }
+
+  if (providers.length === 0) {
+    if ((inputParams && inputParams.yes) || providerPluginList.length === 1) {
+      context.print.info(`Using default provider  ${providerPluginList[0]}`);
+      result = providerPluginList[0]; // eslint-disable-line
+    } else {
+      const selectProvider = {
+        type: 'list',
+        name: 'selectedProvider',
+        message: 'Select the backend provider.',
+        choices: providerPluginList,
+        default: providerPluginList[0],
+      };


Isn't this code similar to the code below. Why can't we expose this as an util and use it here?

amplify-cli/packages/amplify-cli/src/lib/init-steps/s2-initProviders.js

Lines 22 to 52 in 8b225c1

async function getProviders(context, providerPlugins) {

let providers = [];

const providerPluginList = Object.keys(providerPlugins);

const { inputParams } = context.exeInfo;

if (inputParams && inputParams.amplify && inputParams.amplify.providers) {

inputParams.amplify.providers.forEach(provider => {

provider = normalizeProviderName(provider, providerPluginList);

if (provider) {

providers.push(provider);

}

});

}

if (providers.length === 0) {

if ((inputParams && inputParams.yes) || providerPluginList.length === 1) {

context.print.info(`Using default provider ${providerPluginList[0]}`);

providers.push(providerPluginList[0]);

} else {

const selectProviders = {

type: 'checkbox',

name: 'selectedProviders',

message: 'Select the backend providers.',

choices: providerPluginList,

default: providerPluginList[0],

};

const answer = await inquirer.prompt(selectProviders);

providers = answer.selectedProviders;

}

}

return providers;

}

yuth · 2019-11-20T16:04:57Z

packages/amplify-cli/src/lib/attach-backend-steps/a20-analyzeProject.js

+function getDefaultEditor(context) {
+  let defaultEditor;
+  const projectPath = process.cwd();
+  const localEnvFilePath = context.amplify.pathManager.getLocalEnvFilePath(projectPath);
+  if (fs.existsSync(localEnvFilePath)) {
+    ({ defaultEditor } = readJsonFile(localEnvFilePath));
+  }
+
+  return defaultEditor;
+}


amplify-cli/packages/amplify-cli/src/lib/init-steps/s0-analyzeProject.js

Lines 200 to 209 in 8b225c1

function getDefaultEditor(context) {

let defaultEditor;

const projectPath = process.cwd();

const localEnvFilePath = context.amplify.pathManager.getLocalEnvFilePath(projectPath);

if (fs.existsSync(localEnvFilePath)) {

({ defaultEditor } = readJsonFile(localEnvFilePath));

}

return defaultEditor;

}

yuth · 2019-11-20T16:07:00Z

packages/amplify-cli/src/lib/attach-backend-steps/a20-analyzeProject.js

+async function getEditor(context) {
+  let editor;
+  if (context.exeInfo.inputParams.amplify && context.exeInfo.inputParams.amplify.defaultEditor) {
+    editor = normalizeEditor(context.exeInfo.inputParams.amplify.defaultEditor);
+  } else if (!context.exeInfo.inputParams.yes) {
+    editor = await editorSelection(editor);
+  }
+
+  return editor;
+}


amplify-cli/packages/amplify-cli/src/lib/init-steps/s0-analyzeProject.js

Lines 101 to 109 in 8b225c1

async function getEditor(context) {

let editor;

if (context.exeInfo.inputParams.amplify && context.exeInfo.inputParams.amplify.defaultEditor) {

editor = normalizeEditor(context.exeInfo.inputParams.amplify.defaultEditor);

} else if (!context.exeInfo.inputParams.yes) {

editor = await editorSelection(editor);

}

return editor;

yuth · 2019-11-20T16:15:51Z

packages/amplify-cli/src/lib/attach-backend-steps/a30-initFrontend.js

+async function getFrontendHandler(context, frontendPlugins, suitableFrontend) {
+  let frontend;
+  const frontendPluginList = Object.keys(frontendPlugins);
+  const { inputParams } = context.exeInfo;
+
+  if (inputParams && inputParams.amplify && inputParams.amplify.frontend) {
+    frontend = normalizeFrontendHandlerName(inputParams.amplify.frontend, frontendPluginList);
+  }
+
+  if (!frontend && inputParams && inputParams.yes) {
+    frontend = 'javascript';
+  }
+
+  if (!frontend) {
+    const selectFrontendHandler = {
+      type: 'list',
+      name: 'selectedFrontendHandler',
+      message: "Choose the type of app that you're building",
+      choices: frontendPluginList,
+      default: suitableFrontend,
+    };
+    const answer = await inquirer.prompt(selectFrontendHandler);
+    frontend = answer.selectedFrontendHandler;
+  }


amplify-cli/packages/amplify-cli/src/lib/init-steps/s1-initFrontend.js

Lines 35 to 60 in 8b225c1

async function getFrontendHandler(context, frontendPlugins, suitableFrontend) {

let frontend;

const frontendPluginList = Object.keys(frontendPlugins);

const { inputParams } = context.exeInfo;

if (inputParams && inputParams.amplify.frontend) {

frontend = normalizeFrontendHandlerName(inputParams.amplify.frontend, frontendPluginList);

}

if (!frontend && inputParams && inputParams.yes) {

frontend = 'javascript';

}

if (!frontend) {

const selectFrontendHandler = {

type: 'list',

name: 'selectedFrontendHandler',

message: "Choose the type of app that you're building",

choices: frontendPluginList,

default: suitableFrontend,

};

const answer = await inquirer.prompt(selectFrontendHandler);

frontend = answer.selectedFrontendHandler;

}

return frontend;

}

yuth · 2019-11-20T16:23:40Z

packages/amplify-cli/src/lib/attach-backend-steps/a40-generateFiles.js

@@ -0,0 +1,109 @@
+const fs = require('fs-extra');


This is almost similar to the file below. Can we extract out the common part and reuse it in both places

amplify-cli/packages/amplify-cli/src/lib/init-steps/s9-onSuccess.js

Lines 1 to 152 in 8b225c1

const fs = require('fs-extra');

const sequential = require('promise-sequential');

const { getFrontendPlugins } = require('../../extensions/amplify-helpers/get-frontend-plugins');

const { getProviderPlugins } = require('../../extensions/amplify-helpers/get-provider-plugins');

const gitManager = require('../../extensions/amplify-helpers/git-manager');

const { initializeEnv } = require('../initialize-env');

const { readJsonFile } = require('../../extensions/amplify-helpers/read-json-file');

async function run(context) {

const { projectPath } = context.exeInfo.localEnvInfo;

const { amplify } = context;

const amplifyDirPath = amplify.pathManager.getAmplifyDirPath(projectPath);

const dotConfigDirPath = amplify.pathManager.getDotConfigDirPath(projectPath);

const backendDirPath = amplify.pathManager.getBackendDirPath(projectPath);

const currentBackendDirPath = amplify.pathManager.getCurrentCloudBackendDirPath(projectPath);

fs.ensureDirSync(amplifyDirPath);

fs.ensureDirSync(dotConfigDirPath);

fs.ensureDirSync(backendDirPath);

fs.ensureDirSync(currentBackendDirPath);

// Get current-cloud-backend's amplify-meta

const currentAmplifyMetafilePath = amplify.pathManager.getCurentAmplifyMetaFilePath();

let currentAmplifyMeta = {};

if (fs.existsSync(currentAmplifyMetafilePath)) {

currentAmplifyMeta = readJsonFile(currentAmplifyMetafilePath);

}

const providerPlugins = getProviderPlugins(context);

const providerOnSuccessTasks = [];

const frontendPlugins = getFrontendPlugins(context);

const frontendModule = require(frontendPlugins[context.exeInfo.projectConfig.frontend]);

await frontendModule.onInitSuccessful(context);

generateLocalRuntimeFiles(context);

generateNonRuntimeFiles(context);

context.exeInfo.projectConfig.providers.forEach(provider => {

const providerModule = require(providerPlugins[provider]);

providerOnSuccessTasks.push(() => providerModule.onInitSuccessful(context));

});

await sequential(providerOnSuccessTasks);

await initializeEnv(context, currentAmplifyMeta);

if (!context.parameters.options.app) {

printWelcomeMessage(context);

}

// Exit the process with a success code

// process.exit(0);

}

function generateLocalRuntimeFiles(context) {

generateLocalEnvInfoFile(context);

generateAmplifyMetaFile(context);

}

function generateLocalEnvInfoFile(context) {

const { projectPath } = context.exeInfo.localEnvInfo;

const jsonString = JSON.stringify(context.exeInfo.localEnvInfo, null, 4);

const localEnvFilePath = context.amplify.pathManager.getLocalEnvFilePath(projectPath);

fs.writeFileSync(localEnvFilePath, jsonString, 'utf8');

}

function generateAmplifyMetaFile(context) {

if (context.exeInfo.isNewEnv) {

const { projectPath } = context.exeInfo.localEnvInfo;

const jsonString = JSON.stringify(context.exeInfo.amplifyMeta, null, 4);

const currentBackendMetaFilePath = context.amplify.pathManager.getCurentAmplifyMetaFilePath(projectPath);

fs.writeFileSync(currentBackendMetaFilePath, jsonString, 'utf8');

const backendMetaFilePath = context.amplify.pathManager.getAmplifyMetaFilePath(projectPath);

fs.writeFileSync(backendMetaFilePath, jsonString, 'utf8');

}

}

function generateNonRuntimeFiles(context) {

generateProjectConfigFile(context);

generateBackendConfigFile(context);

generateProviderInfoFile(context);

generateGitIgnoreFile(context);

}

function generateProjectConfigFile(context) {

// won't modify on new env

if (context.exeInfo.isNewProject) {

const { projectPath } = context.exeInfo.localEnvInfo;

const jsonString = JSON.stringify(context.exeInfo.projectConfig, null, 4);

const projectConfigFilePath = context.amplify.pathManager.getProjectConfigFilePath(projectPath);

fs.writeFileSync(projectConfigFilePath, jsonString, 'utf8');

}

}

function generateProviderInfoFile(context) {

const { projectPath } = context.exeInfo.localEnvInfo;

let teamProviderInfo = {};

const providerInfoFilePath = context.amplify.pathManager.getProviderInfoFilePath(projectPath);

if (fs.existsSync(providerInfoFilePath)) {

teamProviderInfo = readJsonFile(providerInfoFilePath);

Object.assign(teamProviderInfo, context.exeInfo.teamProviderInfo);

} else {

({ teamProviderInfo } = context.exeInfo);

}

const jsonString = JSON.stringify(teamProviderInfo, null, 4);

fs.writeFileSync(providerInfoFilePath, jsonString, 'utf8');

}

function generateBackendConfigFile(context) {

if (context.exeInfo.isNewProject) {

const { projectPath } = context.exeInfo.localEnvInfo;

const backendConfigFilePath = context.amplify.pathManager.getBackendConfigFilePath(projectPath);

fs.writeFileSync(backendConfigFilePath, '{}', 'utf8');

}

}

function generateGitIgnoreFile(context) {

if (context.exeInfo.isNewProject) {

const { projectPath } = context.exeInfo.localEnvInfo;

const gitIgnoreFilePath = context.amplify.pathManager.getGitIgnoreFilePath(projectPath);

gitManager.insertAmplifyIgnore(gitIgnoreFilePath);

}

}

function printWelcomeMessage(context) {

context.print.info('');

context.print.success('Your project has been successfully initialized and connected to the cloud!');

context.print.info('');

context.print.success('Some next steps:');

context.print.info('"amplify status" will show you what you\'ve added already and if it\'s locally configured or deployed');

context.print.info('"amplify <category> add" will allow you to add features like user login or a backend API');

context.print.info('"amplify push" will build all your local backend resources and provision it in the cloud');

context.print.info(

'"amplify publish" will build all your local backend and frontend resources (if you have hosting category added) and provision it in the cloud'

);

context.print.info('');

context.print.success('Pro tip:');

context.print.info('Try "amplify add api" to create a backend API and then "amplify publish" to deploy everything');

context.print.info('');

}

module.exports = {

run,

generateLocalEnvInfoFile,

};

I initially tried, but there are too many special handlings, doing that will make code maintenance very hard.

I am not saying it should be the same file. But rather move the common pieces in to a distinct function for instance

Have a function to ensure all the directories exists

generateLocalEnvInfoFile

generateNonRuntimeFiles

generateProjectConfigFile

generateGitIgnoreFile

generateBackendConfigFile (with slight refactor to handle both new and existing project)

Will address the code duplications.

yuth · 2019-11-20T16:25:27Z

packages/amplify-cli/src/lib/attach-backend.js

+function backupAmplifyFolder(context) {
+  const projectPath = process.cwd();
+  const amplifyDirPath = context.amplify.pathManager.getAmplifyDirPath(projectPath);
+  if (fs.existsSync(amplifyDirPath)) {
+    const backupAmplifyDirPath = path.join(projectPath, backupAmplifyDirName);
+    fs.moveSync(amplifyDirPath, backupAmplifyDirPath);
+  }
+}
+
+function restoreOriginalAmplifyFolder(context) {
+  const projectPath = process.cwd();
+  const backupAmplifyDirPath = path.join(projectPath, backupAmplifyDirName);
+  if (fs.existsSync(backupAmplifyDirPath)) {
+    const amplifyDirPath = context.amplify.pathManager.getAmplifyDirPath(projectPath);
+    fs.removeSync(amplifyDirPath);
+    fs.moveSync(backupAmplifyDirPath, amplifyDirPath);
+  }
+}
+
+function removeBackupAmplifyFolder() {
+  const projectPath = process.cwd();
+  const backupAmplifyDirPath = path.join(projectPath, backupAmplifyDirName);


Thes could go to thier own module

yuth · 2019-11-20T16:29:01Z

packages/amplify-cli/src/lib/pull-backend.js

+  context.exeInfo = context.amplify.getProjectDetails();
+  context.exeInfo.inputParams = constructInputParams(context);
+  context.print.info('');
+  context.print.info('Pre pull check:');


this should be fired as an event and the check should happen in the event handler

currently we don't have pre pull event

yuth · 2019-11-20T16:29:25Z

packages/amplify-cli/src/lib/pull-backend.js

+  }
+
+  await initializeEnv(context);
+  await postPullCodeGenCheck(context);


this should also be an event

Agree.
But we've decided to leave it as an empty operation for now.

Even so it should be fired as an event which can either be consumed or not. We should start making use of the event system we have built as it would open for other plugin to consume these events

I can mark this as todo, currently there is no pre-pull and post-pull events yet.

yuth · 2019-11-20T18:29:38Z

packages/amplify-provider-awscloudformation/package.json

@@ -11,7 +11,7 @@
    "amplify-category-storage": "1.31.0",
    "amplify-codegen": "1.29.0",
    "archiver": "^2.1.1",
-    "aws-sdk": "^2.510.0",
+    "aws-sdk": "file:../../aws-sdk/",


We can't merge this till sdk gets published and this change is removed

yuth · 2019-11-20T18:30:07Z

packages/amplify-provider-awscloudformation/src/aws-utils/aws-amplify.js

+const configurationManager = require('../../lib/configuration-manager');
+
+// const betaEndpoint = 'https://ntb76nklh1.execute-api.us-west-2.amazonaws.com/beta';
+const gammaEndpoint = 'https://e3alza85jk.execute-api.us-west-2.amazonaws.com/gamma';


same here. We should not publish/merge this till the change is available in prod

yuth · 2019-11-20T18:31:20Z

packages/amplify-provider-awscloudformation/src/aws-utils/aws-amplify.js

+  }
+
+  const defaultOptions = {
+    region: 'us-west-2',


region is hardcoded. Shouldn't we use the project region?

this is only for beta testing, removed.

yuth · 2019-11-20T18:34:52Z

packages/amplify-provider-awscloudformation/src/aws-utils/aws-amplify.js

+    // ignore missing config
+  }
+
+  let endpoint = gammaEndpoint;


lets not have the default, since we do support overriding this value with env vars

this is already removed.

yuth · 2019-11-20T18:35:54Z

packages/amplify-provider-awscloudformation/lib/push-resources.js

@@ -51,6 +52,9 @@ async function run(context, resourceDefinition) {
      }
    })
    .then(() => postPushGraphQLCodegen(context))
+    .then(async () => {
+      await amplifyServiceManager.postPushCheck(context);


Don't we have events for post push in the new plugin platform? Cant we use that instead of doing it here

generally, yes.
But this is for migration of projects setup by CLI prior to this update, it has to happen here to insert the appId's into the right places.

yuth · 2019-11-20T18:49:04Z

packages/amplify-provider-awscloudformation/lib/attach-backend.js

+
+    return selection;
+  } else if (apps.length === 1) {
+    context.print.info(`Found one amplify project '${apps[0].name} / ${apps[0].appId}'`);


Found existing amplify project '${apps[0].name} / ${apps[0].appId}'

wording is decided by the PM.

Was this wording chosen by the PM? If not would we be having a separate PR for changing the wording?

Was chosen in discussions, then he proof read it.
Not sure why this should be changed. The message here is that " there is ONE app" in the account, and prompt the user to confirm to choose it.

Do not handle custom logic for one or multiple Amplify Console apps.

yuth · 2019-11-20T18:53:26Z

packages/amplify-provider-awscloudformation/lib/attach-backend.js

+function getConfiguredS3Client(awsConfig) {
+  const httpProxy = process.env.HTTP_PROXY || process.env.HTTPS_PROXY;
+
+  if (httpProxy) {
+    aws.config.update({
+      httpOptions: {
+        agent: proxyAgent(httpProxy),
+      },
+    });
+  }
+
+  return new aws.S3({ ...awsConfig });
+}
+
+module.exports = {
+  run,
+};


Why are we using the directly? We have helper methods in aws-utils module to get an S3 client

I used the existing s3 client implementation in the amplify-service-manager.js line 333 in the storeArtifcatsForAmplifyService method.
I can not use the S3 client directly here, because in its upload files method, it's expecting a project that's already setup by the Amplify CLI and has the teamProviderInfo and LocalEnvInfo etc. In the attach backend workflow, those items are not there and are to be setup by the workflow.
We need refactor the S3 client in the aws-utils to make it more flexible.

yuth · 2019-11-20T18:57:29Z

packages/amplify-provider-awscloudformation/lib/amplify-service-manager.js

+      context.print.error(`Input Amplify appId is invalild: ${inputAmplifyAppId}`);
+      context.print.info(e);
+      throw e;


Should we treat all errors the same? What about network errors? Can we just show the error only if the service sends an error saying application is not found?

I don't know the error code for that, and there's no documentation.
Will update when it's available.
But this shouldn't happen very often.

Could you speak to the console team to get the possible error codes. If we can't get this for initial release could you add a todo here and create task for it so that we have some way of tracking this

lgtm-com · 2019-11-21T22:57:26Z

This pull request introduces 2 alerts when merging cbd0c77 into cc96a05 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

lgtm-com · 2019-11-21T23:11:06Z

This pull request introduces 2 alerts when merging b9fb4a9 into cc96a05 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

yuth · 2019-11-22T15:37:45Z

packages/amplify-cli/src/commands/console.js

  },
 };
+
+function constructStatusURL(appId, envName) {
+  const prodURL = `https://console.aws.amazon.com/amplify/home#/${appId}/YmFja2VuZA/${envName}`; // eslint-disable-line


what is YmFja2VuZA in the url? Would it be same for every customer?

Yes it would be. Orangebox automatically resolved the region.

yuth · 2019-11-22T15:38:12Z

packages/amplify-cli/src/commands/console.js

+}
+
+function getDefaultURL() {
+  const prodURL = `https://console.aws.amazon.com/amplify/home#/create`; // eslint-disable-line


Why eslint disable?

yuth · 2019-11-22T15:55:59Z

packages/amplify-cli/src/lib/attach-backend-steps/a10-queryProvider.js

@@ -0,0 +1,63 @@
+const inquirer = require('inquirer');


most of the code here are identical to

amplify-cli/packages/amplify-cli/src/lib/init-steps/s2-initProviders.js

Lines 1 to 56 in 84b523d

const inquirer = require('inquirer');

const sequential = require('promise-sequential');

const { getProviderPlugins } = require('../../extensions/amplify-helpers/get-provider-plugins');

const { normalizeProviderName } = require('../input-params-manager');

async function run(context) {

const providerPlugins = getProviderPlugins(context);

const providers = await getProviders(context, providerPlugins);

context.exeInfo.projectConfig.providers = providers;

const initializationTasks = [];

providers.forEach(provider => {

const providerModule = require(providerPlugins[provider]);

initializationTasks.push(() => providerModule.init(context));

});

await sequential(initializationTasks);

return context;

}

async function getProviders(context, providerPlugins) {

let providers = [];

const providerPluginList = Object.keys(providerPlugins);

const { inputParams } = context.exeInfo;

if (inputParams && inputParams.amplify && inputParams.amplify.providers) {

inputParams.amplify.providers.forEach(provider => {

provider = normalizeProviderName(provider, providerPluginList);

if (provider) {

providers.push(provider);

}

});

}

if (providers.length === 0) {

if ((inputParams && inputParams.yes) || providerPluginList.length === 1) {

context.print.info(`Using default provider ${providerPluginList[0]}`);

providers.push(providerPluginList[0]);

} else {

const selectProviders = {

type: 'checkbox',

name: 'selectedProviders',

message: 'Select the backend providers.',

choices: providerPluginList,

default: providerPluginList[0],

};

const answer = await inquirer.prompt(selectProviders);

providers = answer.selectedProviders;

}

}

return providers;

}

module.exports = {

run,

};

and

amplify-cli/packages/amplify-cli/src/lib/config-steps/c2-configProviders.js

Lines 1 to 67 in 84b523d

const inquirer = require('inquirer');

const sequential = require('promise-sequential');

const { getProviderPlugins } = require('../../extensions/amplify-helpers/get-provider-plugins');

const { normalizeProviderName } = require('../input-params-manager');

async function run(context) {

const providerPlugins = getProviderPlugins(context);

const { providers: currentProviders } = context.exeInfo.projectConfig;

const selectedProviders = await configureProviders(context, providerPlugins, currentProviders);

const configTasks = [];

const initializationTasks = [];

const onInitSuccessfulTasks = [];

selectedProviders.forEach(provider => {

const providerModule = require(providerPlugins[provider]);

if (currentProviders.includes(provider)) {

configTasks.push(() => providerModule.configure(context));

} else {

initializationTasks.push(() => providerModule.init(context));

onInitSuccessfulTasks.push(() => providerModule.onInitSuccessful(context));

}

});

await sequential(configTasks);

await sequential(initializationTasks);

await sequential(onInitSuccessfulTasks);

return context;

}

async function configureProviders(context, providerPlugins, currentProviders) {

let providers = [];

const providerPluginList = Object.keys(providerPlugins);

const { inputParams } = context.exeInfo;

if (inputParams.amplify.providers) {

inputParams.amplify.providers.forEach(provider => {

provider = normalizeProviderName(provider, providerPluginList);

if (provider) {

providers.push(provider);

}

});

}

if (providers.length === 0) {

if (inputParams.yes || providerPluginList.length === 1) {

context.print.info(`Using default provider ${providerPluginList[0]}`);

providers.push(providerPluginList[0]);

} else {

const selectProviders = {

type: 'checkbox',

name: 'selectedProviders',

message: 'Select the backend providers.',

choices: providerPluginList,

default: currentProviders,

};

const answer = await inquirer.prompt(selectProviders);

providers = answer.selectedProviders;

}

}

return providers;

}

module.exports = {

run,

};

Can we move the common code to a separate module and use it instead of having different copies of the same code

yuth · 2019-11-22T16:08:52Z

packages/amplify-cli/src/lib/attach-backend-steps/a40-generateFiles.js

@@ -0,0 +1,109 @@
+const fs = require('fs-extra');


I am not saying it should be the same file. But rather move the common pieces in to a distinct function for instance

Have a function to ensure all the directories exists

generateLocalEnvInfoFile

generateNonRuntimeFiles

generateProjectConfigFile

generateGitIgnoreFile

generateBackendConfigFile (with slight refactor to handle both new and existing project)

yuth · 2019-11-22T16:12:46Z

packages/amplify-cli/src/lib/pull-backend.js

+  }
+
+  await initializeEnv(context);
+  await postPullCodeGenCheck(context);


Even so it should be fired as an event which can either be consumed or not. We should start making use of the event system we have built as it would open for other plugin to consume these events

yuth · 2019-11-22T16:21:38Z

packages/amplify-provider-awscloudformation/lib/attach-backend.js

+
+    return selection;
+  } else if (apps.length === 1) {
+    context.print.info(`Found one amplify project '${apps[0].name} / ${apps[0].appId}'`);


Was this wording chosen by the PM? If not would we be having a separate PR for changing the wording?

yuth · 2019-11-22T16:24:32Z

packages/amplify-provider-awscloudformation/lib/push-resources.js

@@ -49,6 +50,7 @@ async function run(context, resourceDefinition) {
    }

    await postPushGraphQLCodegen(context);
+    await amplifyServiceManager.postPushCheck(context);


Lets make use of post push events. If we can't get to it now, add a todo

yuth · 2019-11-22T16:30:39Z

packages/amplify-provider-awscloudformation/lib/configuration-manager.js

+  if (httpProxy) {
+    awsConfig = {
+      ...awsConfig,
+      httpOptions: { agent: proxyAgent(httpProxy) },
+    };
+  }
+
+  return awsConfig;


could this be part of any loadConfiguration so that proxy is set up everytime

yuth · 2019-11-22T16:31:30Z

packages/amplify-provider-awscloudformation/src/aws-utils/aws-amplify.js

+  if (httpProxy) {
+    aws.config.update({
+      httpOptions: {
+        agent: proxyAgent(httpProxy),
+      },
+    });
+  }
+


If the proxy setup is added to load configuration, we don't need it here and all the other utils will also get proxy support

yuth · 2019-11-22T16:32:41Z

packages/amplify-provider-awscloudformation/src/aws-utils/aws-amplify.js

+const amplifyServiceRegions = [
+  'us-east-1',
+  'us-east-2',
+  'us-west-2',
+  'eu-west-1',
+  'eu-west-2',
+  'eu-central-1',
+  'ap-northeast-1',
+  'ap-northeast-2',
+  'ap-south-1',
+  'ap-southeast-1',
+  'ap-southeast-2',
+];


could we have single mapping file for all the services instead of it being scattered in different files.

attilah

My comments are addressed, approving, other's comments need to be addressed as well before merge.

swaminator

Provided a number of language changes.

swaminator · 2019-11-22T20:40:09Z

packages/amplify-cli/src/lib/attach-backend.js

+  await postPullCodeGenCheck(context);
+
+  if (!inputParams.yes) {
+    const confirmKeepCodebase = await context.amplify.confirmPrompt.run('Do you want to keep the backend codebase?', true);


Do you plan on modifying this backend? (Y/n/Learn more)
Learn more:
You have a choice to pull the entire backend definition (infrastructure templates and metadata) or only the metadata (the backend config file) required to connect to the backend. If you want to modify or add new categories to your backend choose 'Yes'. If you want to connect to the backend without making any backend changes choose 'No'. If you’re building a mobile and web app in separate repositories, the recommended workflow is to keep the backend definition (the amplify folder) in only one of the repositories and pull the metadata (the aws-exports or amplifyconfiguration.json file) in the second repository to connect to the same backend.

changed the words.
"learn more" will be in another PR

swaminator · 2019-11-22T20:41:02Z

packages/amplify-cli/src/lib/attach-backend.js

+    const confirmKeepCodebase = await context.amplify.confirmPrompt.run('Do you want to keep the backend codebase?', true);
+    if (confirmKeepCodebase) {
+      context.print.info('');
+      context.print.success('Backend environment has been successfully pulled and attached to your project.');


The suggested wording has not been implemented: "✔ Successfully pulled backend environment '$envname' from the cloud."

swaminator · 2019-11-22T20:41:20Z

packages/amplify-cli/src/lib/attach-backend.js

+    } else {
+      removeFolderStructure(context);
+      context.print.info('');
+      context.print.success('Backend environment configuration has been successfully pulled.');


✔ Successfully pulled backend environment '$envname' from the cloud.

swaminator · 2019-11-22T20:43:45Z

packages/amplify-cli/src/lib/initialize-env.js

    await sequential(initializationTasks);
-    spinner.succeed('Initialized provider successfully.');
+    spinner.succeed(isPulling ? 'Successfully pulled your current backend environment.' : 'Initialized provider successfully.');


✔ Successfully pulled backend environment '$envname' from the cloud.

swaminator · 2019-11-22T20:52:13Z

packages/amplify-cli/src/lib/initialize-env.js

@@ -53,9 +58,9 @@ async function initializeEnv(context, currentAmplifyMeta) {
      initializationTasks.push(() => providerModule.initEnv(context, amplifyMeta.providers[provider]));
    });

-    spinner.start(`Initializing your environment: ${currentEnv}`);
+    spinner.start(isPulling ? `Pulling current backend for environment: ${currentEnv}` : `Initializing your environment: ${currentEnv}`);


Fetching updates to backend environment: ${currentEnv} from the cloud.

swaminator · 2019-11-22T21:27:36Z

packages/amplify-provider-awscloudformation/lib/attach-backend.js

+          environmentName: inputEnvName,
+        })
+        .promise();
+      context.print.info(`Input envName ${inputEnvName} is verified in Amplify service project ${amplifyApp.name}.`);


Backend environment ${inputEnvName} found in Amplify Console app: ${amplifyApp.name}

swaminator · 2019-11-22T21:28:14Z

packages/amplify-provider-awscloudformation/lib/attach-backend.js

+      context.print.info(`Input envName ${inputEnvName} is verified in Amplify service project ${amplifyApp.name}.`);
+      return getBackendEnvironmentResult.backendEnvironment;
+    } catch (e) {
+      context.print.error(`Input envName ${inputEnvName} is invalid in Amplify service project ${amplifyApp.name}.`);


Cannot find backend environment ${inputEnvName} in Amplify Console app: ${amplifyApp.name}

swaminator · 2019-11-22T21:30:36Z

packages/amplify-provider-awscloudformation/lib/attach-backend.js

+    return selection;
+  } else if (apps.length === 1) {
+    context.print.info(`Found one amplify project '${apps[0].name} / ${apps[0].appId}'`);
+    const confirmMigrateMessage = 'Do you want to choose it?';


Confirm the selection? (y/N)

swaminator · 2019-11-22T21:31:09Z

packages/amplify-provider-awscloudformation/lib/attach-backend.js

+    return selection;
+  } else if (backendEnvs.length === 1) {
+    context.print.info(`Found one backend environment '${backendEnvs[0].environmentName}'`);
+    const confirmMigrateMessage = 'Do you want to choose it?';


The recommendation was for when the user only has one Amplify backend environment to automatically select it. The language above is different from what I recommended. "Backend environment '$envname' found. Initializing.." and to get rid of the 'Do you want to choose it'

swaminator · 2019-11-22T21:31:27Z

packages/amplify-provider-awscloudformation/lib/attach-backend.js

+      return backendEnvs[0];
+    }
+  } else {
+    const errorMessage = `Found no currently existing backend environment in the amplify project: ${amplifyApp.name}.`;


Cannot find backend environment ${inputEnvName} in Amplify Console app: ${amplifyApp.name}

github-actions · 2021-05-25T06:11:05Z

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

feat(cli): cLI updates and new features for Amplify Console

62fa864

change amplify console command

df87b2d

dev

1069ea0

add migraiton check in attach workflow

478ccc6

dev

fc8b1a8

dev

3ce6695

yuth requested review from yuth, attilah and ammarkarachi November 19, 2019 02:16

yuth assigned attilah, yuth and ammarkarachi Nov 19, 2019

ammarkarachi reviewed Nov 20, 2019

View reviewed changes

attilah suggested changes Nov 20, 2019

View reviewed changes

yuth reviewed Nov 20, 2019

View reviewed changes

ammarkarachi approved these changes Nov 20, 2019

View reviewed changes

ammarkarachi self-requested a review November 20, 2019 17:56

yuth suggested changes Nov 20, 2019

View reviewed changes

UnleashedMind added 5 commits November 20, 2019 17:06

allow pulling different env

52e613f

update message printout

3e91b06

region map

1230480

update aws-sdk version

07194d0

yarn

9d705a3

UnleashedMind added 3 commits November 21, 2019 14:06

handle unsupported region of Amplify service

769b77a

handle unsupported regions of Amplify service

0813c94

merge upstream

cbd0c77

yarn

b9fb4a9

UnleashedMind added 2 commits November 21, 2019 17:33

dev

b8e07e8

address PR review comments

84b523d

yuth suggested changes Nov 22, 2019

View reviewed changes

attilah approved these changes Nov 22, 2019

View reviewed changes

aws-amplify deleted a comment from UnleashedMind Nov 22, 2019

swaminator requested changes Nov 22, 2019

View reviewed changes

text changes to address PR review comments

54e495b

swaminator approved these changes Nov 22, 2019

View reviewed changes

yuth approved these changes Nov 23, 2019

View reviewed changes

UnleashedMind merged commit 0fd0dd5 into aws-amplify:master Nov 23, 2019

RossWilliams mentioned this pull request Jan 3, 2020

Improved changelog and release notes, human readable updates #2574

Open

This was referenced Jan 6, 2020

Please add "amplify pull" #174

Closed

expose amplify pull in amplify help docs and on README #3125

Closed

github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021

		@@ -35,7 +44,11 @@ function updateBackendConfigDependsOn(category, resourceName, attribute, value)

		function updateBackendConfigAfterResourceRemove(category, resourceName) {
		const backendConfigFilePath = pathManager.getBackendConfigFilePath();

	async function getProviders(context, providerPlugins) {
	let providers = [];
	const providerPluginList = Object.keys(providerPlugins);
	const { inputParams } = context.exeInfo;
	if (inputParams && inputParams.amplify && inputParams.amplify.providers) {
	inputParams.amplify.providers.forEach(provider => {
	provider = normalizeProviderName(provider, providerPluginList);
	if (provider) {
	providers.push(provider);
	}
	});
	}

	if (providers.length === 0) {
	if ((inputParams && inputParams.yes) \|\| providerPluginList.length === 1) {
	context.print.info(`Using default provider ${providerPluginList[0]}`);
	providers.push(providerPluginList[0]);
	} else {
	const selectProviders = {
	type: 'checkbox',
	name: 'selectedProviders',
	message: 'Select the backend providers.',
	choices: providerPluginList,
	default: providerPluginList[0],
	};
	const answer = await inquirer.prompt(selectProviders);
	providers = answer.selectedProviders;
	}
	}
	return providers;
	}

	function getDefaultEditor(context) {
	let defaultEditor;
	const projectPath = process.cwd();
	const localEnvFilePath = context.amplify.pathManager.getLocalEnvFilePath(projectPath);
	if (fs.existsSync(localEnvFilePath)) {
	({ defaultEditor } = readJsonFile(localEnvFilePath));
	}

	return defaultEditor;
	}

	async function getEditor(context) {
	let editor;
	if (context.exeInfo.inputParams.amplify && context.exeInfo.inputParams.amplify.defaultEditor) {
	editor = normalizeEditor(context.exeInfo.inputParams.amplify.defaultEditor);
	} else if (!context.exeInfo.inputParams.yes) {
	editor = await editorSelection(editor);
	}

	return editor;

	async function getFrontendHandler(context, frontendPlugins, suitableFrontend) {
	let frontend;
	const frontendPluginList = Object.keys(frontendPlugins);
	const { inputParams } = context.exeInfo;
	if (inputParams && inputParams.amplify.frontend) {
	frontend = normalizeFrontendHandlerName(inputParams.amplify.frontend, frontendPluginList);
	}

	if (!frontend && inputParams && inputParams.yes) {
	frontend = 'javascript';
	}

	if (!frontend) {
	const selectFrontendHandler = {
	type: 'list',
	name: 'selectedFrontendHandler',
	message: "Choose the type of app that you're building",
	choices: frontendPluginList,
	default: suitableFrontend,
	};
	const answer = await inquirer.prompt(selectFrontendHandler);
	frontend = answer.selectedFrontendHandler;
	}

	return frontend;
	}

	const fs = require('fs-extra');
	const sequential = require('promise-sequential');
	const { getFrontendPlugins } = require('../../extensions/amplify-helpers/get-frontend-plugins');
	const { getProviderPlugins } = require('../../extensions/amplify-helpers/get-provider-plugins');
	const gitManager = require('../../extensions/amplify-helpers/git-manager');
	const { initializeEnv } = require('../initialize-env');
	const { readJsonFile } = require('../../extensions/amplify-helpers/read-json-file');

	async function run(context) {
	const { projectPath } = context.exeInfo.localEnvInfo;
	const { amplify } = context;

	const amplifyDirPath = amplify.pathManager.getAmplifyDirPath(projectPath);
	const dotConfigDirPath = amplify.pathManager.getDotConfigDirPath(projectPath);
	const backendDirPath = amplify.pathManager.getBackendDirPath(projectPath);
	const currentBackendDirPath = amplify.pathManager.getCurrentCloudBackendDirPath(projectPath);

	fs.ensureDirSync(amplifyDirPath);
	fs.ensureDirSync(dotConfigDirPath);
	fs.ensureDirSync(backendDirPath);
	fs.ensureDirSync(currentBackendDirPath);

	// Get current-cloud-backend's amplify-meta
	const currentAmplifyMetafilePath = amplify.pathManager.getCurentAmplifyMetaFilePath();

	let currentAmplifyMeta = {};

	if (fs.existsSync(currentAmplifyMetafilePath)) {
	currentAmplifyMeta = readJsonFile(currentAmplifyMetafilePath);
	}

	const providerPlugins = getProviderPlugins(context);
	const providerOnSuccessTasks = [];

	const frontendPlugins = getFrontendPlugins(context);
	const frontendModule = require(frontendPlugins[context.exeInfo.projectConfig.frontend]);

	await frontendModule.onInitSuccessful(context);

	generateLocalRuntimeFiles(context);
	generateNonRuntimeFiles(context);

	context.exeInfo.projectConfig.providers.forEach(provider => {
	const providerModule = require(providerPlugins[provider]);
	providerOnSuccessTasks.push(() => providerModule.onInitSuccessful(context));
	});

	await sequential(providerOnSuccessTasks);

	await initializeEnv(context, currentAmplifyMeta);

	if (!context.parameters.options.app) {
	printWelcomeMessage(context);
	}
	// Exit the process with a success code
	// process.exit(0);
	}

	function generateLocalRuntimeFiles(context) {
	generateLocalEnvInfoFile(context);
	generateAmplifyMetaFile(context);
	}

	function generateLocalEnvInfoFile(context) {
	const { projectPath } = context.exeInfo.localEnvInfo;
	const jsonString = JSON.stringify(context.exeInfo.localEnvInfo, null, 4);
	const localEnvFilePath = context.amplify.pathManager.getLocalEnvFilePath(projectPath);
	fs.writeFileSync(localEnvFilePath, jsonString, 'utf8');
	}

	function generateAmplifyMetaFile(context) {
	if (context.exeInfo.isNewEnv) {
	const { projectPath } = context.exeInfo.localEnvInfo;
	const jsonString = JSON.stringify(context.exeInfo.amplifyMeta, null, 4);
	const currentBackendMetaFilePath = context.amplify.pathManager.getCurentAmplifyMetaFilePath(projectPath);
	fs.writeFileSync(currentBackendMetaFilePath, jsonString, 'utf8');
	const backendMetaFilePath = context.amplify.pathManager.getAmplifyMetaFilePath(projectPath);
	fs.writeFileSync(backendMetaFilePath, jsonString, 'utf8');
	}
	}

	function generateNonRuntimeFiles(context) {
	generateProjectConfigFile(context);
	generateBackendConfigFile(context);
	generateProviderInfoFile(context);
	generateGitIgnoreFile(context);
	}

	function generateProjectConfigFile(context) {
	// won't modify on new env
	if (context.exeInfo.isNewProject) {
	const { projectPath } = context.exeInfo.localEnvInfo;
	const jsonString = JSON.stringify(context.exeInfo.projectConfig, null, 4);
	const projectConfigFilePath = context.amplify.pathManager.getProjectConfigFilePath(projectPath);
	fs.writeFileSync(projectConfigFilePath, jsonString, 'utf8');
	}
	}

	function generateProviderInfoFile(context) {
	const { projectPath } = context.exeInfo.localEnvInfo;
	let teamProviderInfo = {};
	const providerInfoFilePath = context.amplify.pathManager.getProviderInfoFilePath(projectPath);
	if (fs.existsSync(providerInfoFilePath)) {
	teamProviderInfo = readJsonFile(providerInfoFilePath);
	Object.assign(teamProviderInfo, context.exeInfo.teamProviderInfo);
	} else {
	({ teamProviderInfo } = context.exeInfo);
	}

	const jsonString = JSON.stringify(teamProviderInfo, null, 4);
	fs.writeFileSync(providerInfoFilePath, jsonString, 'utf8');
	}

	function generateBackendConfigFile(context) {
	if (context.exeInfo.isNewProject) {
	const { projectPath } = context.exeInfo.localEnvInfo;
	const backendConfigFilePath = context.amplify.pathManager.getBackendConfigFilePath(projectPath);
	fs.writeFileSync(backendConfigFilePath, '{}', 'utf8');
	}
	}

	function generateGitIgnoreFile(context) {
	if (context.exeInfo.isNewProject) {
	const { projectPath } = context.exeInfo.localEnvInfo;

	const gitIgnoreFilePath = context.amplify.pathManager.getGitIgnoreFilePath(projectPath);

	gitManager.insertAmplifyIgnore(gitIgnoreFilePath);
	}
	}

	function printWelcomeMessage(context) {
	context.print.info('');
	context.print.success('Your project has been successfully initialized and connected to the cloud!');
	context.print.info('');
	context.print.success('Some next steps:');
	context.print.info('"amplify status" will show you what you\'ve added already and if it\'s locally configured or deployed');
	context.print.info('"amplify <category> add" will allow you to add features like user login or a backend API');
	context.print.info('"amplify push" will build all your local backend resources and provision it in the cloud');
	context.print.info(
	'"amplify publish" will build all your local backend and frontend resources (if you have hosting category added) and provision it in the cloud'
	);
	context.print.info('');
	context.print.success('Pro tip:');
	context.print.info('Try "amplify add api" to create a backend API and then "amplify publish" to deploy everything');
	context.print.info('');
	}

	module.exports = {
	run,
	generateLocalEnvInfoFile,
	};

	const inquirer = require('inquirer');
	const sequential = require('promise-sequential');
	const { getProviderPlugins } = require('../../extensions/amplify-helpers/get-provider-plugins');
	const { normalizeProviderName } = require('../input-params-manager');

	async function run(context) {
	const providerPlugins = getProviderPlugins(context);
	const providers = await getProviders(context, providerPlugins);
	context.exeInfo.projectConfig.providers = providers;
	const initializationTasks = [];

	providers.forEach(provider => {
	const providerModule = require(providerPlugins[provider]);
	initializationTasks.push(() => providerModule.init(context));
	});

	await sequential(initializationTasks);

	return context;
	}

	async function getProviders(context, providerPlugins) {
	let providers = [];
	const providerPluginList = Object.keys(providerPlugins);
	const { inputParams } = context.exeInfo;
	if (inputParams && inputParams.amplify && inputParams.amplify.providers) {
	inputParams.amplify.providers.forEach(provider => {
	provider = normalizeProviderName(provider, providerPluginList);
	if (provider) {
	providers.push(provider);
	}
	});
	}

	if (providers.length === 0) {
	if ((inputParams && inputParams.yes) \|\| providerPluginList.length === 1) {
	context.print.info(`Using default provider ${providerPluginList[0]}`);
	providers.push(providerPluginList[0]);
	} else {
	const selectProviders = {
	type: 'checkbox',
	name: 'selectedProviders',
	message: 'Select the backend providers.',
	choices: providerPluginList,
	default: providerPluginList[0],
	};
	const answer = await inquirer.prompt(selectProviders);
	providers = answer.selectedProviders;
	}
	}
	return providers;
	}

	module.exports = {
	run,
	};

feat(cli): cLI updates and new features for Amplify Console #2742

feat(cli): cLI updates and new features for Amplify Console #2742

Conversation

UnleashedMind commented Nov 14, 2019

lgtm-com bot commented Nov 14, 2019

lgtm-com bot commented Nov 15, 2019

lgtm-com bot commented Nov 15, 2019

lgtm-com bot commented Nov 15, 2019

lgtm-com bot commented Nov 15, 2019

lgtm-com bot commented Nov 15, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

attilah left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

UnleashedMind Nov 22, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

UnleashedMind Nov 22, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

UnleashedMind Nov 22, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lgtm-com bot commented Nov 21, 2019

lgtm-com bot commented Nov 21, 2019

UnleashedMind Nov 22, 2019 •

edited

UnleashedMind Nov 22, 2019 •

edited

UnleashedMind Nov 22, 2019 •

edited