Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tearing down environment still does not delete pinpoint #2974

Closed
dantasfiles opened this issue Dec 11, 2019 · 1 comment · Fixed by #3165
Closed

Tearing down environment still does not delete pinpoint #2974

dantasfiles opened this issue Dec 11, 2019 · 1 comment · Fixed by #3165
Assignees
@UnleashedMind
Labels
analytics Issues tied to the analytics category of the CLI bug Something isn't working
Projects
Issue tracking

Comments

@dantasfiles
Copy link

dantasfiles commented Dec 11, 2019 •
edited

Tearing down environment still does not delete pinpoint

Amplify CLI Version
4.6.0

To Reproduce

  • Run npx react-native init AnalyticsTest
  • Run amplify init
  • Run amplify add analytics with all defaults
  • Run amplify push
  • Pinpoint console now contains analyticstest-env
  • Run amplify delete
  • ERROR: Pinpoint console still contains analyticstest-env

According to a previous, closed issue, this was fixed
#1278
But it still occurs in amplify cli v.4.6.0

Desktop

  • OS: Windows
  • Node 12.9.1
@kaustavghosh06 kaustavghosh06 added bug Something isn't working analytics Issues tied to the analytics category of the CLI labels Dec 11, 2019
@kaustavghosh06 kaustavghosh06 added this to Weimin bugs in Issue tracking Dec 18, 2019
UnleashedMind added a commit to UnleashedMind/amplify-cli that referenced this issue Jan 8, 2020
@UnleashedMind
fix(amplify-category-notifications): delete command to remove pinpoint
2234012 
currently the amplify delete command does not remove the Pinpoint project, this commet fixes the bug

fix aws-amplify#2974
@kaustavghosh06 kaustavghosh06 moved this from Weimin bugs to Ammar bugs in Issue tracking Jan 10, 2020
@kaustavghosh06 kaustavghosh06 moved this from Ammar bugs to Work-In-Progress in Issue tracking Jan 10, 2020
@UnleashedMind UnleashedMind mentioned this issue Jan 11, 2020
Merged
UnleashedMind pushed a commit to UnleashedMind/amplify-cli that referenced this issue Mar 3, 2020
fix(amplify-category-analytics): delete pinpoint project in delete
a10ae95 
fix aws-amplify#2974
UnleashedMind added a commit that referenced this issue Mar 9, 2020
@UnleashedMind
fix(amplify-category-analytics): delete pinpoint project in delete (#…
acc0240 
…3165)

* fix(amplify-category-analytics): delete pinpoint project in delete

fix #2974

* test(amplify-e2e-tests): add e2e test for pinpoint project delete

* update for changed analytics prompt

* typo correction

Co-authored-by: Zhou <zhoweimi@186590ce137f.ant.amazon.com>
@UnleashedMind UnleashedMind moved this from Work-In-Progress to Merged/Closed in Issue tracking Mar 23, 2020
@github-actions
Copy link

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@UnleashedMind UnleashedMind

Labels
analytics Issues tied to the analytics category of the CLI bug Something isn't working
Projects
No open projects
Issue tracking
Merged/Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(amplify-category-analytics): delete pinpoint project in delete UnleashedMind/amplify-cli
3 participants
@UnleashedMind @kaustavghosh06 @dantasfiles