AWS Pinpoint Campaign testing push notifications with APNS Sandbox does not start working after amplify add notifications

[lawmicha]

Describe the bug
When I enable APNS push notifications with key certificate via amplify add notifications, it appears to be enabled, however when I try to create a campaign and send a test message to my endpointId, it fails with Channel Disabled. The endpoint is set up with a device token for APNS sandbox. When I check settings, push notification is enabled. I checked the amplify-cli code and it looks like it's hitting updateApnsChannel. When using AWS Console to add the key certificate, it then works (device receives the notification) when I send test messages or launch the campaign.

Amplify CLI Version
4.12.0

To Reproduce

1. amplify add analytics and amplify push
2. amplify add notifications

 amplify notifications add
? Choose the push notification channel to enable. APNS
? Choose authentication method used for APNs Key
? The bundle id used for APNs Tokens:  <Your App's BundleID like com.yourname.projectname>
? The team id used for APNs Tokens:  XXXXXXXXX
? The key id used for APNs Tokens:  ABCDEXXXXX
? The key file path (.p8):  AuthKey_ABCDEXXXXX.p8
✔ The APNS channel has been successfully enabled.

3. Make sure an app is registers for push notifications and then registers the token with APNS, and registers an endpoint with device token and APNS Sandbox with pinpoint.
4. Make sure that single endpoint is picked up when choosing a segment when creating a campaign. Try sending a notification using Test message to the endpointId (can be printed out from pinpoint sdk logs), and fails with some message (AWS Console sometimes isn't very verbose, may be easier to test using AWS CLI but I don't have that set up)
5. amplify console analytics and go to the Settings/Push Notifications/Edit, and under APNS re-add the key certificate
6. Try creating a campaign/test message and it works!

I suspect that going through the console, it may be making calls to both update-apns-sandbox-channel and update-apns-channel

Expected behavior
amplify add notifications should allow us to specify apns sandbox or apns production since the key is used for both channels when Pinpoint sends authorization data to APNS. If I have to go to AWS Pinpoint Console to enable calls for APNS Sandbox, that kind of defeats the purpose of using amplify CLI for this step in the development. I think a solution could be by default; make a request to pinpoint to update both apns sandbox and production since that's what the key is used for. And ask Choose APNS environment: [Production|Sandbox|Both] and Both could be the default

Additional context
Some assumptions i've made

• AWS Console/Pinpoint console/Enable notifications/APNS/Add key flow adds it to both APNS sandbox and production. I've only tested that my app starts receiving notifications after using the console, and amplify-cli call doesn't enable it for me since i'm using APNS sandbox.
• Have not verified with AWS CLI to directly call update APNS sandbox and tested that notifications start working after that. Just know that using amplify add notifications results in not working

[lawmicha]

The P8 file, even when generating through apple's developer site indicates it's for both development and production
some related info: https://stackoverflow.com/questions/39672297/how-to-use-apples-new-p8-certificate-for-apns-in-firebase-console

which is why i think if we are registering the p8 file via Amplify CLi, we should simply call both update-apns-sandbox-channel and update-apns-channel. There will never be an option to register different p8 files for development vs production and so it won't make much sense to provide that as an option for the developer and may cause some confusion, plus more work on the developer to have to register it twice.

In terms of error handling, what if one update call fails and the other one succeeds? should we simply convey to the developer that the entire operation failed with the error from pinpoint service and prompt them to try again or open an issue with the repo?

[lawmicha]

thanks for the PR - updating docs aws-amplify/docs#1275

[github-actions]

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.