Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amplify-graphql-types-generator): generate model types #3324

Merged
merged 2 commits into from Jan 20, 2021

Conversation

hirochachacha
Copy link
Contributor

Fixes #3323

  • accumulate return type of operation
  • accumulate object types, interface types and union types
  • generate object types, interface types and union types (for TypeScript)

This PR mainly handles TypeScript. Other frontends may have similary issue.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Feb 3, 2020

Codecov Report

Merging #3324 (9461ffd) into master (df74e0f) will increase coverage by 0.08%.
The diff coverage is 92.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3324      +/-   ##
==========================================
+ Coverage   57.21%   57.30%   +0.08%     
==========================================
  Files         474      474              
  Lines       21609    21666      +57     
  Branches     4078     4306     +228     
==========================================
+ Hits        12364    12415      +51     
+ Misses       8384     8370      -14     
- Partials      861      881      +20     
Impacted Files Coverage Δ
...ify-graphql-types-generator/src/serializeToJSON.ts 84.44% <79.16%> (-7.56%) ⬇️
...l-types-generator/src/typescript/codeGeneration.ts 93.71% <93.18%> (-0.41%) ⬇️
...plify-graphql-types-generator/src/angular/index.ts 96.72% <100.00%> (ø)
...lify-graphql-types-generator/src/compiler/index.ts 91.04% <100.00%> (+0.72%) ⬆️
...graphql-types-generator/src/flow/codeGeneration.js 94.90% <100.00%> (-0.13%) ⬇️
...plify-graphql-types-generator/src/flow/language.js 96.96% <100.00%> (ø)
...graphql-types-generator/src/typescript/language.ts 92.59% <100.00%> (+2.45%) ⬆️
packages/amplify-util-mock/src/api/api.ts 0.00% <0.00%> (ø)
packages/graphql-mapping-template/src/print.ts 35.29% <0.00%> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df74e0f...9461ffd. Read the comment docs.

@yuth yuth force-pushed the feature/generate_model_types branch from b9f7f53 to 43a661d Compare January 20, 2021 19:05
@hirochachacha hirochachacha requested a review from a team as a code owner January 20, 2021 19:05
@lgtm-com
Copy link

lgtm-com bot commented Jan 20, 2021

This pull request introduces 1 alert when merging 43a661d into df74e0f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@yuth yuth force-pushed the feature/generate_model_types branch from 43a661d to 5d6922b Compare January 20, 2021 21:00
@yuth yuth force-pushed the feature/generate_model_types branch from 5d6922b to 9461ffd Compare January 20, 2021 21:05
Copy link
Contributor

@akshbhu akshbhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate model type for type interchangeability
5 participants