Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: data inconsitency #5344

Merged
merged 3 commits into from
Sep 23, 2020

Conversation

ammarkarachi
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #5344 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5344      +/-   ##
==========================================
+ Coverage   59.82%   59.83%   +0.01%     
==========================================
  Files         394      395       +1     
  Lines       17579    17602      +23     
  Branches     3489     3311     -178     
==========================================
+ Hits        10516    10532      +16     
- Misses       6429     6454      +25     
+ Partials      634      616      -18     
Impacted Files Coverage Δ
...awscloudformation/handlers/get-add-auth-handler.ts 27.77% <0.00%> (-1.64%) ⬇️
...amplify-category-notifications/lib/channel-APNS.js 62.50% <0.00%> (-0.72%) ⬇️
packages/amplify-category-xr/commands/xr/push.js 30.00% <0.00%> (-3.34%) ⬇️
packages/amplify-category-xr/lib/xr-manager.js 13.13% <0.00%> (-0.10%) ⬇️
packages/amplify-cli/src/index.ts 48.51% <37.50%> (-0.97%) ⬇️
.../amplify-category-auth/src/commands/auth/update.js 46.42% <100.00%> (+0.97%) ⬆️
packages/amplify-cli-core/src/errors/index.ts 100.00% <100.00%> (ø)
packages/amplify-cli-core/src/index.ts 100.00% <100.00%> (ø)
packages/amplify-cli/src/commands/delete.ts 100.00% <100.00%> (ø)
packages/amplify-util-mock/src/api/api.ts 0.00% <0.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2c03f8...90d8bfe. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Sep 18, 2020

This pull request introduces 2 alerts when merging 2eee96a into d2c03f8 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@ammarkarachi ammarkarachi changed the title fix: success and fail shows up for same session fix: data inconsitency Sep 21, 2020
Copy link
Contributor

@akshbhu akshbhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some LGTM errors of unused variables otherwise LGTM!!

@ammarkarachi ammarkarachi merged commit bfe1903 into aws-amplify:master Sep 23, 2020
r0zar pushed a commit to r0zar/amplify-cli that referenced this pull request Nov 19, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants