Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for mobile hub migrated resources #5407

Merged
merged 7 commits into from
Sep 30, 2020
Merged

fix: add support for mobile hub migrated resources #5407

merged 7 commits into from
Sep 30, 2020

Conversation

attilah
Copy link
Contributor

@attilah attilah commented Sep 25, 2020

Description of changes:

fix: add support for mobile hub migrated resources

  • support push/pull operations
  • support CRUD permission assignment to migrated resources
  • block multi-env commands
  • block update and remove operations on migrated resources
  • better error message in some cases

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- support push/pull operations
- support CRUD permission assignment to migrated resources
- block multi-env commands
- block update and remove operations on migrated resources
@lgtm-com
Copy link

lgtm-com bot commented Sep 25, 2020

This pull request introduces 1 alert when merging 31a0e3f into c630145 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #5407 into master will decrease coverage by 0.06%.
The diff coverage is 24.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5407      +/-   ##
==========================================
- Coverage   59.08%   59.01%   -0.07%     
==========================================
  Files         400      401       +1     
  Lines       18002    18049      +47     
  Branches     3568     3579      +11     
==========================================
+ Hits        10636    10652      +16     
- Misses       6717     6743      +26     
- Partials      649      654       +5     
Impacted Files Coverage Δ
packages/amplify-category-auth/src/index.js 10.67% <0.00%> (-0.07%) ⬇️
...fy-category-notifications/lib/multi-env-manager.js 0.00% <0.00%> (ø)
...ategory-notifications/lib/notifications-manager.js 0.00% <0.00%> (ø)
...ackages/amplify-cli/src/utils/mobilehub-support.ts 43.47% <43.47%> (ø)
.../amplify-category-auth/src/commands/auth/update.js 67.39% <66.66%> (-0.11%) ⬇️
packages/amplify-cli/src/index.ts 49.03% <75.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc21870...cf0004f. Read the comment docs.

@ammarkarachi ammarkarachi merged commit 5dfe287 into aws-amplify:master Sep 30, 2020
yuth pushed a commit to yuth/amplify-cli that referenced this pull request Oct 2, 2020
* fix: add support for mobile hub migrated resources

- support push/pull operations
- support CRUD permission assignment to migrated resources
- block multi-env commands
- block update and remove operations on migrated resources

* fix: sigint test failure

* chore: fix lgtm warning

* fix: add 'add notification' and 'update auth' protection

* chore: fix update unit test
r0zar pushed a commit to r0zar/amplify-cli that referenced this pull request Nov 19, 2020
* fix: add support for mobile hub migrated resources

- support push/pull operations
- support CRUD permission assignment to migrated resources
- block multi-env commands
- block update and remove operations on migrated resources

* fix: sigint test failure

* chore: fix lgtm warning

* fix: add 'add notification' and 'update auth' protection

* chore: fix update unit test
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants