Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor mobile hub migration checks #5632

Merged
merged 2 commits into from
Oct 21, 2020
Merged

fix: refactor mobile hub migration checks #5632

merged 2 commits into from
Oct 21, 2020

Conversation

attilah
Copy link
Contributor

@attilah attilah commented Oct 19, 2020

Description of changes:

The Mobile Hub migrator plugin has changed to include a mobileHubMigrated property on migrated resources. This PR updated the previous checks to be done against this property.

Also mobile hub checks for env commands are re-enabled.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #5632 into master will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5632      +/-   ##
==========================================
- Coverage   57.76%   57.73%   -0.03%     
==========================================
  Files         406      407       +1     
  Lines       18630    18661      +31     
  Branches     3721     3532     -189     
==========================================
+ Hits        10761    10774      +13     
- Misses       7187     7225      +38     
+ Partials      682      662      -20     
Impacted Files Coverage Δ
...fy-category-notifications/lib/multi-env-manager.js 0.00% <0.00%> (ø)
...ategory-notifications/lib/notifications-manager.js 0.00% <0.00%> (ø)
...ackages/amplify-cli/src/utils/mobilehub-support.ts 39.28% <0.00%> (ø)
packages/amplify-cli/src/index.ts 49.03% <50.00%> (+0.52%) ⬆️
.../amplify-category-auth/src/commands/auth/update.js 65.30% <100.00%> (ø)
packages/amplify-util-mock/src/api/api.ts 0.00% <0.00%> (ø)
packages/graphql-mapping-template/src/print.ts 34.65% <0.00%> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
...ges/amplify-util-mock/src/CFNParser/stack/index.ts 0.00% <0.00%> (ø)
...es/amplify-util-mock/src/api/resolver-overrides.ts 0.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f8873...19d9a78. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Oct 19, 2020

This pull request fixes 2 alerts when merging 68b311b into ad50318 - view on LGTM.com

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 19, 2020

This pull request fixes 2 alerts when merging 19d9a78 into ad50318 - view on LGTM.com

fixed alerts:

  • 2 for Unused variable, import, function or class

@akshbhu akshbhu merged commit b796eb8 into aws-amplify:master Oct 21, 2020
r0zar pushed a commit to r0zar/amplify-cli that referenced this pull request Nov 19, 2020
* fix: refactor mobile hub migration checks

* chore: fix comment
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants