-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor mobile hub migration checks #5632
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5632 +/- ##
==========================================
- Coverage 57.76% 57.73% -0.03%
==========================================
Files 406 407 +1
Lines 18630 18661 +31
Branches 3721 3532 -189
==========================================
+ Hits 10761 10774 +13
- Misses 7187 7225 +38
+ Partials 682 662 -20
Continue to review full report at Codecov.
|
This pull request fixes 2 alerts when merging 68b311b into ad50318 - view on LGTM.com fixed alerts:
|
This pull request fixes 2 alerts when merging 19d9a78 into ad50318 - view on LGTM.com fixed alerts:
|
* fix: refactor mobile hub migration checks * chore: fix comment
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Description of changes:
The Mobile Hub migrator plugin has changed to include a
mobileHubMigrated
property on migrated resources. This PR updated the previous checks to be done against this property.Also mobile hub checks for
env
commands are re-enabled.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.