fix(amplify-velocity-template): support 'get' and 'set' of array vars #5741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2 of the unit tests are failing. Could you investigate those |
SwaySway
reviewed
Oct 30, 2020
| }; | ||
| return baseRef; | ||
| if (id === 'get' && !baseRef[id]) { | ||
| return baseRef[this.getLiteral(property.args[0])]; |
There was a problem hiding this comment.
Is there a reason in removing the getter? Referencing this pr: https://github.com/shepherdwind/velocity.js/pull/133/files
yuth
added a commit
to yuth/amplify-cli
that referenced
this pull request
Oct 31, 2020
The implementation of set and get methods of an array in velocity is not working like in the real environment. fix is based on shepherdwind/velocity.js#133 fix aws-amplify#5741
|
Thank you for the PR. The upstream has a fix in shepherdwind/velocity.js#133. closing this in favor of that upstream fix that is merged in #5747 |
yuth
added a commit
to yuth/amplify-cli
that referenced
this pull request
Jan 8, 2021
The implementation of set and get methods of an array in velocity is not working like in the real environment. fix is based on shepherdwind/velocity.js#133 fix aws-amplify#5741
yuth
added a commit
to yuth/amplify-cli
that referenced
this pull request
Jan 16, 2021
The implementation of set and get methods of an array in velocity is not working like in the real environment. fix is based on shepherdwind/velocity.js#133 fix aws-amplify#5741
yuth
added a commit
that referenced
this pull request
Jan 16, 2021
…#5747) The implementation of set and get methods of an array in velocity is not working like in the real environment. fix is based on shepherdwind/velocity.js#133 fix #5741
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #5593
Description of changes: Fixes velocity template to support
setandgetmethods of array variables.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.