-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(amplify-velocity-template): support 'get' and 'set' of array vars #5747
Conversation
This pull request introduces 1 alert when merging 944ad7a into de79514 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #5747 +/- ##
==========================================
+ Coverage 57.21% 58.15% +0.94%
==========================================
Files 474 407 -67
Lines 21605 18747 -2858
Branches 4294 3550 -744
==========================================
- Hits 12361 10903 -1458
+ Misses 8363 7182 -1181
+ Partials 881 662 -219
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tests needs a review @yuth they are failing.
This pull request introduces 1 alert when merging 472edfd into 7a045fb - view on LGTM.com new alerts:
|
The implementation of set and get methods of an array in velocity is not working like in the real environment. fix is based on shepherdwind/velocity.js#133 fix aws-amplify#5741
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
The implementation of set and get methods of an array in velocity is not working like in the real
environment.
fix is based on shepherdwind/velocity.js#133
fix #5741
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.