Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amplify-velocity-template): support 'get' and 'set' of array vars #5747

Merged
merged 4 commits into from
Jan 16, 2021

Conversation

yuth
Copy link
Contributor

@yuth yuth commented Oct 31, 2020

The implementation of set and get methods of an array in velocity is not working like in the real
environment.

fix is based on shepherdwind/velocity.js#133

fix #5741

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lgtm-com
Copy link

lgtm-com bot commented Oct 31, 2020

This pull request introduces 1 alert when merging 944ad7a into de79514 - view on LGTM.com

new alerts:

  • 1 for Variable not declared before use

@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #5747 (de79514) into master (3da53b7) will increase coverage by 0.94%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5747      +/-   ##
==========================================
+ Coverage   57.21%   58.15%   +0.94%     
==========================================
  Files         474      407      -67     
  Lines       21605    18747    -2858     
  Branches     4294     3550     -744     
==========================================
- Hits        12361    10903    -1458     
+ Misses       8363     7182    -1181     
+ Partials      881      662     -219     
Impacted Files Coverage Δ
...ckages/amplify-cli-core/src/jsonValidationError.ts 33.33% <0.00%> (-66.67%) ⬇️
...-appsync-simulator/src/velocity/util/list-utils.ts 33.33% <0.00%> (-66.67%) ⬇️
packages/amplify-cli-core/src/exitOnNextTick.ts 33.33% <0.00%> (-16.67%) ⬇️
...lify-cli/src/extensions/amplify-helpers/make-id.ts 87.50% <0.00%> (-12.50%) ⬇️
packages/amplify-cli-core/src/tags/Tags.ts 69.23% <0.00%> (-9.72%) ⬇️
...ify-codegen/src/callbacks/prePushUpdateCallback.js 58.62% <0.00%> (-3.88%) ⬇️
.../graphql-transformer-core/src/util/sanity-check.ts 11.29% <0.00%> (-3.56%) ⬇️
...s/awscloudformation/utils/auth-request-adaptors.ts 40.20% <0.00%> (-2.80%) ⬇️
...amplify-cli-core/src/feature-flags/featureFlags.ts 80.48% <0.00%> (-2.62%) ⬇️
...psync-simulator/src/velocity/util/general-utils.ts 35.61% <0.00%> (-1.37%) ⬇️
... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3da53b7...e9b05a8. Read the comment docs.

Copy link
Contributor

@attilah attilah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests needs a review @yuth they are failing.

@lgtm-com
Copy link

lgtm-com bot commented Jan 8, 2021

This pull request introduces 1 alert when merging 472edfd into 7a045fb - view on LGTM.com

new alerts:

  • 1 for Variable not declared before use

@yuth yuth marked this pull request as ready for review January 8, 2021 23:44
@yuth yuth requested a review from a team as a code owner January 8, 2021 23:44
@yuth yuth requested a review from attilah January 8, 2021 23:44
@yuth yuth merged commit b5f917a into aws-amplify:master Jan 16, 2021
@yuth yuth deleted the fix-5741 branch January 16, 2021 02:51
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get and set of array values not working in amplify-velocity-template
2 participants