Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pre-deploy pull, new login mechanism and pkg cli updates #5941

Merged
merged 57 commits into from
Nov 30, 2020
Merged

feat: pre-deploy pull, new login mechanism and pkg cli updates #5941

merged 57 commits into from
Nov 30, 2020

Conversation

edwardfoyle
Copy link
Member

Changes to support pre-deploy pull, authenticate with the browser and fixes / optimizations to the packaged CLI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

kaustavghosh06 and others added 30 commits November 21, 2020 12:07
@kaustavghosh06 @edwardfoyle
feat: backend manager pre-deploy pull
39cb80e
@kaustavghosh06 @edwardfoyle
fix: allow for pre-deploy pull after initial pull
250c055
@kaustavghosh06 @edwardfoyle
fix:changing beta url endpoint
b837a55
@kaustavghosh06 @edwardfoyle
add amplify-app to package.json
0da6f31
@kaustavghosh06 @edwardfoyle
update AppState link to point to gamma
e71c66b
@jhockett @edwardfoyle
Admin login (#5694)
e2094ab
@jhockett @edwardfoyle
Admin login update (#5793)
065fcdc
@edwardfoyle
chore: update yarn.lock
7d13d95
@kaustavghosh06 @edwardfoyle
Update package.json
e712efb
@jhockett @edwardfoyle
refactor: admin auth (#5844)
2c8fa5f
@edwardfoyle
chore: fix backendManager npm publish script (#5850)
d39d2c0
@edwardfoyle
chore: fix pub to verdaccio script (#5851)
a0ca027
@edwardfoyle
fix: add dummy git config for pub to verdaccio (#5856)
e53429c
@jhockett @edwardfoyle
fix: handle login cancellation (#5859)
3c4a3b0
@edwardfoyle
chore: change backendManagerAppId to sandboxId (#5881)
8c9f9c3
@edwardfoyle
fix: tweaks to pkg pipeline (#5887)
42144f9
@edwardfoyle
fix: source bashrc before sanity check
05f2073
@edwardfoyle
feat: codegen on pull (#5895)
1dd0d38
@edwardfoyle
feat: init empty aws-exports with amplify-app (#5906)
365e5cd
@jhockett @edwardfoyle
fix: env add/remove, fix imports (#5903)
8f79916
@edwardfoyle
feat: compress bins (#5912)
fb0c9e7
@edwardfoyle
remove ejs from pruning
36e2417
@kaustavghosh06 @edwardfoyle
Update pre-deployment-pull.ts
4b46167
@jhockett @edwardfoyle
fix: file existence checks, enable admin console (#5922)
d5d2ce6
@edwardfoyle
chore: update gql transform dep version
c1d89fb
@edwardfoyle
chore: update pub to verdaccio script
f323eb2
@edwardfoyle
chore: update unified changelog script
d152a04
@jhockett
fix: support disabling admin (#5928)
7323252
@edwardfoyle
Merge remote-tracking branch 'upstream/master' into backendManager
21686a3
@edwardfoyle
chore: update pkg install sanity check
21cd673
attilah
attilah previously requested changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@attilah attilah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a bunch of comments, some questions.

In general these concernts are valid for the whole change:

  • appId === undefined is not handled anywhere when checking for admin app and such, neither for isAmplifyAdminApp or doAdminCredentialsExist.
  • what is the use case when customer has 25 apps?

There are no tests yet, no unit tests or e2e.

packages/amplify-app/package.json Show resolved Hide resolved
packages/amplify-app/src/call-amplify.js Show resolved Hide resolved
packages/amplify-app/src/index.js Outdated Show resolved Hide resolved
...ategory-api/src/provider-utils/awscloudformation/service-walkthroughs/appSync-walkthrough.ts Outdated Show resolved Hide resolved
...ategory-api/src/provider-utils/awscloudformation/service-walkthroughs/appSync-walkthrough.ts Show resolved Hide resolved
packages/amplify-provider-awscloudformation/src/utils/admin-login-server.ts Outdated Show resolved Hide resolved
packages/amplify-provider-awscloudformation/src/utils/admin-login-server.ts Outdated Show resolved Hide resolved
packages/amplify-provider-awscloudformation/src/utils/admin-login-server.ts Outdated Show resolved Hide resolved
scripts/github-common.ts Outdated Show resolved Hide resolved
scripts/github-prerelease.ts Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Nov 27, 2020

This pull request introduces 1 alert when merging 8fd5bdc into eb4f23d - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 27, 2020

This pull request introduces 1 alert when merging 770f53c into eb4f23d - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@jhockett jhockett mentioned this pull request Nov 29, 2020
Merged
@lgtm-com
Copy link

lgtm-com bot commented Nov 29, 2020

This pull request introduces 1 alert when merging 5bb6734 into 7d48378 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@jhockett jhockett changed the title pre-deploy pull, new login mechanism and pkg cli updates feat: pre-deploy pull, new login mechanism and pkg cli updates Nov 30, 2020
@kaustavghosh06 kaustavghosh06 dismissed attilah’s stale review November 30, 2020 01:14

resolved concerned in the conversations above.

@kaustavghosh06 kaustavghosh06 requested review from kaustavghosh06 and removed request for attilah and yuth November 30, 2020 01:15
kaustavghosh06
kaustavghosh06 approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@kaustavghosh06 kaustavghosh06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kaustavghosh06 kaustavghosh06 merged commit 7274251 into master Nov 30, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2021
@danielleadams danielleadams deleted the backendManager branch November 21, 2022 19:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jhockett jhockett jhockett left review comments

@renebrandel renebrandel renebrandel left review comments

@nikhname nikhname nikhname left review comments

@ammarkarachi ammarkarachi ammarkarachi left review comments

@kaustavghosh06 kaustavghosh06 kaustavghosh06 approved these changes

@attilah attilah attilah left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@edwardfoyle @ammarkarachi @attilah @jhockett @renebrandel @kaustavghosh06 @nikhname