Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to disable opening browser when amplify publish completes? #5973

Closed
Coteh opened this issue Nov 25, 2020 · 3 comments · Fixed by #6503
Closed

Is it possible to disable opening browser when amplify publish completes? #5973

Coteh opened this issue Nov 25, 2020 · 3 comments · Fixed by #6503
Assignees
Labels
feature-request Request a new feature hosting Issues tied to hosting category
Projects

Comments

@Coteh
Copy link

Coteh commented Nov 25, 2020

Which Category is your question related to?
Amplify Hosting

Amplify CLI Version
4.29.2

What AWS Services are you utilizing?
AppSync, S3

Provide additional details e.g. code snippets
Maybe this can be refiled under Feature Request if it doesn't exist, but I was just wondering if there's a CI/CD option for amplify publish to not open up web browser with deployed app once it completes. I checked CI/CD page and Amplify Hosting page of the CLI documentation and I don't see anything for such a thing.

A little bit of background, we use Jenkins for CI/CD and our build agent is a macOS box that happens to have GUI installed. Whenever the Jenkins agent runs pipeline to deploy our web app using Amplify, there's a web browser that ends up being opened on that page. The other dev I'm working on this project with thinks that this could be fixed by not specifying a default browser, but I wonder if there's any options in Amplify CLI that can prevent browser window from being opened in the first place.

I assume most CI/CD machines are truly headless (ie. no GUI) so we're probably a special case, but I think it would still be nice to have an option that completely prevents CLI from opening a window. And if there is actually something in the docs I missed, please let me know. Thanks.

@ammarkarachi ammarkarachi added enhancement hosting Issues tied to hosting category labels Nov 26, 2020
@ammarkarachi ammarkarachi added this to To do in Bug bash via automation Nov 26, 2020
@ammarkarachi
Copy link
Contributor

@Coteh it looks like by default it is set to open the browser, I will mark this as an enhancement to be worked by the team

@yuth yuth self-assigned this Jan 28, 2021
@yuth yuth moved this from To do to In progress in Bug bash Jan 28, 2021
yuth added a commit to yuth/amplify-cli that referenced this issue Jan 28, 2021
Updated the CLI not to open browser window when running in CI mode

re aws-amplify#5973
@yuth yuth moved this from In progress to Review in Bug bash Jan 28, 2021
yuth added a commit to yuth/amplify-cli that referenced this issue Jan 29, 2021
Updated the CLI not to open browser window when running in CI mode

re aws-amplify#5973
@yuth yuth linked a pull request Jan 29, 2021 that will close this issue
Bug bash automation moved this from Review to Done Feb 10, 2021
yuth added a commit that referenced this issue Feb 10, 2021
Updated the CLI not to open browser window when running in CI mode

re #5973
@FabioNevesAbreu1
Copy link

Hi, i thing that i have the same issue but when amplify pull in a headless mode, can you verify for me?
anyone have the same issue than me?

@github-actions
Copy link

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
@josefaidt josefaidt added feature-request Request a new feature and removed enhancement labels Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request a new feature hosting Issues tied to hosting category
Projects
Bug bash
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants