Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #6097 - don't create build folder during dry run #6133

Merged
merged 1 commit into from
Dec 11, 2020
Merged

fix: #6097 - don't create build folder during dry run #6133

merged 1 commit into from
Dec 11, 2020

Conversation

attilah
Copy link
Contributor

@attilah attilah commented Dec 10, 2020

Issue #, if available:

fix: #6097 - don't create build folder during dry run

Description of changes:

This PR fixes the 2nd half, the root cause of the referenced issue, so a full API build will happen upon push.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #6133 (e510932) into master (9c4281f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #6133    +/-   ##
========================================
  Coverage   56.99%   56.99%            
========================================
  Files         466      466            
  Lines       21395    21395            
  Branches     4029     4244   +215     
========================================
  Hits        12194    12194            
+ Misses       8252     8232    -20     
- Partials      949      969    +20     
Impacted Files Coverage Δ
packages/amplify-util-mock/src/api/api.ts 0.00% <0.00%> (ø)
packages/graphql-mapping-template/src/print.ts 35.29% <0.00%> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
...ges/amplify-util-mock/src/CFNParser/stack/index.ts 0.00% <0.00%> (ø)
...es/amplify-util-mock/src/api/resolver-overrides.ts 0.00% <0.00%> (ø)
...es/graphql-transformer-core/src/stripDirectives.ts 35.29% <0.00%> (ø)
.../amplify-cli-core/src/state-manager/pathManager.ts 67.85% <0.00%> (ø)
.../amplify-util-mock/src/utils/lambda/loadMinimal.ts 0.00% <0.00%> (ø)
...graphql-transformer-core/src/TransformerContext.ts 25.09% <0.00%> (ø)
...mplify-appsync-simulator/src/resolvers/function.ts 15.38% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c4281f...e510932. Read the comment docs.

@PeteDuncanson
Copy link

Do we know an ETA for getting this one out into a release? Currently blocked from deploying due to this one.

@SwaySway SwaySway merged commit b22e491 into aws-amplify:master Dec 11, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Parser error in Amplify
5 participants