Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: container based deployments on native projects #6201

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

elorzafe
Copy link
Contributor

Issue #, if available:

Description of changes:
Native projects were missing to enable container based deployments

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lgtm-com
Copy link

lgtm-com bot commented Dec 17, 2020

This pull request introduces 2 alerts when merging 15976be into af54abe - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #6201 (af54abe) into master (af54abe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6201   +/-   ##
=======================================
  Coverage   57.01%   57.01%           
=======================================
  Files         467      467           
  Lines       21472    21472           
  Branches     4267     4267           
=======================================
  Hits        12242    12242           
  Misses       8255     8255           
  Partials      975      975           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8445b...0dc3a99. Read the comment docs.

@elorzafe elorzafe marked this pull request as ready for review December 18, 2020 00:45
@elorzafe elorzafe requested a review from a team as a code owner December 18, 2020 00:45
@elorzafe elorzafe force-pushed the fix/native-container-question branch from be18b2f to b5bddc2 Compare December 18, 2020 01:36
Copy link
Contributor

@nikhname nikhname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jhockett jhockett merged commit 5ebcae8 into aws-amplify:master Jan 6, 2021
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants