Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): handle undefined enabledProviders #6293

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

cwoolum
Copy link
Contributor

@cwoolum cwoolum commented Dec 31, 2020

*Issue #, if available: #6285

*Description of changes: Handled the providers being undefined and also refactored a bit for readability. Added 4 unit tests as well

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@jhockett jhockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution @cwoolum!

@codecov
Copy link

codecov bot commented Dec 31, 2020

Codecov Report

Merging #6293 (6d4bfa5) into master (450616e) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6293      +/-   ##
==========================================
+ Coverage   57.03%   57.12%   +0.08%     
==========================================
  Files         469      471       +2     
  Lines       21514    21554      +40     
  Branches     4057     4066       +9     
==========================================
+ Hits        12271    12313      +42     
+ Misses       8383     8381       -2     
  Partials      860      860              
Impacted Files Coverage Δ
...xtensions/amplify-helpers/service-select-prompt.ts 94.59% <100.00%> (ø)
...c/extensions/amplify-helpers/get-project-config.ts 100.00% <0.00%> (ø)
...extensions/amplify-helpers/get-provider-plugins.ts 83.33% <0.00%> (+66.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 450616e...6d4bfa5. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Dec 31, 2020

This pull request fixes 1 alert when merging 6d4bfa5 into 48604f6 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@jhockett jhockett merged commit b57b05d into aws-amplify:master Jan 4, 2021
@github-actions
Copy link

github-actions bot commented Jan 5, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error message when cloud provider not yet configured
2 participants