Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply tags on create and push nested stack #6321

Merged
merged 2 commits into from
Jan 7, 2021
Merged

fix: apply tags on create and push nested stack #6321

merged 2 commits into from
Jan 7, 2021

Conversation

ammarkarachi
Copy link
Contributor

@ammarkarachi ammarkarachi commented Jan 6, 2021 •
edited

Issue #, if available:

Description of changes:
The goal of this PR is to apply tags when the rootstack is initialized

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ammarkarachi ammarkarachi requested a review from a team as a code owner January 6, 2021 02:26
@lgtm-com
Copy link

lgtm-com bot commented Jan 6, 2021

This pull request introduces 1 alert when merging 010e6c0 into 091e148 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Jan 6, 2021 •
edited

Codecov Report

Merging #6321 (091e148) into master (091e148) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6321   +/-   ##
=======================================
  Coverage   57.12%   57.12%           
=======================================
  Files         471      471           
  Lines       21554    21554           
  Branches     4066     4066           
=======================================
  Hits        12313    12313           
  Misses       8381     8381           
  Partials      860      860

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 091e148...acc516c. Read the comment docs.

attilah
attilah approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@attilah attilah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one change only to not to reimplement object comparison.

packages/amplify-cli/src/extensions/amplify-helpers/resource-status.ts Outdated
if (allResources.filter(resource => resource.category === 'provider').length === 0) {
tagsUpdated = false;
}
const tagsUpdated = compareTags(stateManager.getProjectTags(), stateManager.getCurrentProjectTags());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for compareTags just use _.isEqual

@attilah attilah merged commit 4faa3e5 into aws-amplify:master Jan 7, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jan 7, 2021

This pull request introduces 1 alert when merging acc516c into 8cc85d0 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@github-actions
Copy link

github-actions bot commented Jan 8, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@attilah attilah attilah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ammarkarachi @attilah