fix(amplify-category-function): use ref for S3Bucket and S3Key in CFN

[jhockett]

Issue #, if available:
Closes #5387

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[lgtm-com]

This pull request introduces 3 alerts when merging 3f0c9b0 into 7a045fb - view on LGTM.com

new alerts:

• 3 for Superfluous trailing arguments

[codecov]

Codecov Report

Merging #6358 (0624bd3) into master (b5f917a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #6358    +/-   ##
========================================
  Coverage   57.21%   57.21%            
========================================
  Files         474      474            
  Lines       21609    21609            
  Branches     4078     4295   +217     
========================================
  Hits        12364    12364            
+ Misses       8384     8364    -20     
- Partials      861      881    +20     

Impacted Files	Coverage Δ
packages/amplify-cli-core/src/index.ts	94.73% <ø> (ø)
packages/amplify-util-mock/src/api/api.ts	0.00% <0.00%> (ø)
packages/graphql-mapping-template/src/print.ts	35.29% <0.00%> (ø)
packages/amplify-util-mock/src/storage/storage.ts	0.00% <0.00%> (ø)
...ges/amplify-util-mock/src/CFNParser/stack/index.ts	0.00% <0.00%> (ø)
...es/amplify-util-mock/src/api/resolver-overrides.ts	0.00% <0.00%> (ø)
...es/graphql-transformer-core/src/stripDirectives.ts	35.29% <0.00%> (ø)
.../amplify-cli-core/src/state-manager/pathManager.ts	67.44% <0.00%> (ø)
.../amplify-util-mock/src/utils/lambda/loadMinimal.ts	0.00% <0.00%> (ø)
...graphql-transformer-core/src/TransformerContext.ts	25.09% <0.00%> (ø)
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5f917a...0624bd3. Read the comment docs.

[edwardfoyle]

just one question, but LGTM

[r0zar]

👏 🎉 thanks @jhockett

[Nxtra]

Does this mean I have to manually update my existing functions?

[jhockett]

Does this mean I have to manually update my existing functions?

No, it should be taken care of automatically on the next amplify push. Did you run into any issues?

[Nxtra]

Does this mean I have to manually update my existing functions?

No, it should be taken care of automatically on the next amplify push. Did you run into any issues?

My existing functions weren't updated. But I now see, that you have to touch the function. Eg adding a console.log, there by having the function recognized as updated, will trigger the changes in the cloudformation template.

[github-actions]

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.