Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ascii art collapsed #6833

Closed
4 tasks done
ginpei opened this issue Mar 9, 2021 · 7 comments
Closed
4 tasks done

Ascii art collapsed #6833

ginpei opened this issue Mar 9, 2021 · 7 comments
Assignees
Labels
feature-request Request a new feature platform Issues tied to the general CLI platform

Comments

@ginpei
Copy link

ginpei commented Mar 9, 2021

Before opening, please confirm:

  • I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
  • I have searched for duplicate or closed issues.
  • I have read the guide for submitting bug reports.
  • I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?

npm

If applicable, what version of Node.js are you using?

v14.15.1

Amplify CLI Version

4.45.0

What operating system are you using?

Ubuntu 20.04 (WSL2 on Windows10)

Amplify Categories

Not applicable

Amplify Commands

Not applicable

Describe the bug

The ascii art shown when you run just amplify is collapsed (see attached image)

Expected behavior

The ascii art should look beautiful

Reproduction steps

Run amplify without args in CLI.

It occurred on VS Code Terminal in default window size with hidden side bar. In my Windows, full-width fonts are used (Japanese)

Log output

# Put your logs below this line

```bash
$ amplify


| Category      |
| ------------- |
| notifications |
| analytics     |
| api           |
| auth          |
| function      |
| hosting       |
| interactions  |
| predictions   |
| storage       |
| xr            |
                                                                                                  
 █████╗ ███╗   ███╗██████╗ ██╗     ██╗███████╗██╗   ██╗    ███████╗██████╗  █████╗ ███╗   ███╗████
███╗██╗    ██╗ ██████╗ ██████╗ ██╗  ██╗                                                           
██╔══██╗████╗ ████║██╔══██╗██║     ██║██╔════╝╚██╗ ██╔╝    ██╔════╝██╔══██╗██╔══██╗████╗ ████║██╔═
═══╝██║    ██║██╔═══██╗██╔══██╗██║ ██╔╝                                                           
███████║██╔████╔██║██████╔╝██║     ██║█████╗   ╚████╔╝     █████╗  ██████╔╝███████║██╔████╔██║████
█╗  ██║ █╗ ██║██║   ██║██████╔╝█████╔╝                                                            
██╔══██║██║╚██╔╝██║██╔═══╝ ██║     ██║██╔══╝    ╚██╔╝      ██╔══╝  ██╔══██╗██╔══██║██║╚██╔╝██║██╔═
═╝  ██║███╗██║██║   ██║██╔══██╗██╔═██╗                                                            
██║  ██║██║ ╚═╝ ██║██║     ███████╗██║██║        ██║       ██║     ██║  ██║██║  ██║██║ ╚═╝ ██║████
███╗╚███╔███╔╝╚██████╔╝██║  ██║██║  ██╗
╚═╝  ╚═╝╚═╝     ╚═╝╚═╝     ╚══════╝╚═╝╚═╝        ╚═╝       ╚═╝     ╚═╝  ╚═╝╚═╝  ╚═╝╚═╝     ╚═╝╚═══
═══╝ ╚══╝╚══╝  ╚═════╝ ╚═╝  ╚═╝╚═╝  ╚═╝

…

Collapsed
image

Looks good in wider screen
image

@watilde
Copy link
Contributor

watilde commented Mar 9, 2021

Full width font is often used in Japanese OS and might be in the other multibyte languages as well. We might want to consider to stop using ASCII or having unicode-off option as same as npm.

Refs:

@attilah attilah added enhancement platform Issues tied to the general CLI platform labels Mar 9, 2021
@attilah
Copy link
Contributor

attilah commented Mar 9, 2021

@ginpei thanks for the issue, I marked it as an enhancement.

@ginpei
Copy link
Author

ginpei commented Mar 10, 2021

By the way, just curious though, I'm wondering how it's supposed to be. Would anyone please share how it look in the western environment?

@cjihrig
Copy link
Contributor

cjihrig commented Mar 10, 2021

It's supposed to say "AMPLIFY FRAMEWORK" like in https://user-images.githubusercontent.com/355808/110403555-20af1f80-8032-11eb-99a8-77d212128b48.png.

@ginpei
Copy link
Author

ginpei commented Mar 10, 2021

So it just expects wider screen regardless font thing. Thank you so much!

@kaustavghosh06
Copy link
Contributor

PR #6497 has been merged to remove the ASCII art and will be part of the next release.

@github-actions
Copy link

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2021
@josefaidt josefaidt added feature-request Request a new feature and removed enhancement labels Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request a new feature platform Issues tied to the general CLI platform
Projects
None yet
Development

No branches or pull requests

7 participants