Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update list bucket policies for s3 triggers #6497

Merged
merged 2 commits into from
Jan 29, 2021

Conversation

akshbhu
Copy link
Contributor

@akshbhu akshbhu commented Jan 28, 2021

*Issue #5528

Description of changes:

  • Added List bucket actions for S3 Triggers in both storage category and functions category.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #6497 (c55b1a1) into master (525deb6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6497   +/-   ##
=======================================
  Coverage   57.28%   57.28%           
=======================================
  Files         479      479           
  Lines       21692    21692           
  Branches     4311     4311           
=======================================
  Hits        12426    12426           
  Misses       8385     8385           
  Partials      881      881           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 525deb6...c55b1a1. Read the comment docs.

Copy link
Contributor

@jhockett jhockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhockett jhockett merged commit b09ccf0 into aws-amplify:master Jan 29, 2021
@kaustavghosh06 kaustavghosh06 mentioned this pull request Mar 26, 2021
4 tasks
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 bucket storage permissions on a lambda function - incorrect policy statement for s3:ListBucket action
2 participants