New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: headless command for geo -- map #8403
feat: headless command for geo -- map #8403
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8403 +/- ##
==========================================
- Coverage 57.17% 57.13% -0.05%
==========================================
Files 725 725
Lines 40915 40969 +54
Branches 8385 8395 +10
==========================================
+ Hits 23395 23407 +12
- Misses 16709 16751 +42
Partials 811 811
Continue to review full report at Codecov.
|
This pull request introduces 1 alert when merging fa8a973 into 7309d96 - view on LGTM.com new alerts:
|
This pull request fixes 2 alerts when merging a3e736a into 7309d96 - view on LGTM.com fixed alerts:
|
This pull request fixes 2 alerts when merging b244723 into 7309d96 - view on LGTM.com fixed alerts:
|
This pull request fixes 2 alerts when merging d403cc0 into e190292 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Things to note before releasing this:
- Add
remove
headless command. - e2e tests to verify that common use-cases work as expected. This can be a separate PR.
"description": "The name of the map that will be created.", | ||
"type": "string" | ||
}, | ||
"mapStyle": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We can probably define this separately like pricingPlan
and AccessType
.
d403cc0
to
9f3725b
Compare
This pull request fixes 2 alerts when merging 9f3725b into 39fbe6f - view on LGTM.com fixed alerts:
|
This pull request fixes 2 alerts when merging 70d9811 into 39fbe6f - view on LGTM.com fixed alerts:
|
This pull request introduces 1 alert and fixes 2 when merging 1edd1aa into f72e59b - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! remove
headless command and e2e tests to be added later.
Description of changes
Add headless command support for geo category, including
add map
update map
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.