New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update endpoints to use custom domains in admin-helpers.ts #8495
fix: update endpoints to use custom domains in admin-helpers.ts #8495
Conversation
Problem: The AppState API Gateway default endpoints have been hardcoded in the CLI configuration which puts a direct coupling between the CLI configuration and the AppState infrastructure where changes to the API infrastructure would require the CLI to be hot patched. Solution: Remove the hardcoded endpoints and replace with deterministic custom domains that do not change. Testing Done: yarn setup-dev
This pull request introduces 5 alerts when merging 06f08ce into 7a18644 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #8495 +/- ##
=======================================
Coverage 52.75% 52.75%
=======================================
Files 514 514
Lines 25921 25921
Branches 5058 5058
=======================================
Hits 13675 13675
Misses 11278 11278
Partials 968 968
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srquinn21 it looks like there's some duplicate regions in the object according to the LGTM errors.
Problem: The AppState API Gateway default endpoints have been hardcoded in the CLI configuration which puts a direct coupling between the CLI configuration and the AppState infrastructure where changes to the API infrastructure would require the CLI to be hot patched. Solution: Remove the hardcoded endpoints and replace with deterministic custom domains that do not change. Testing Done: yarn setup-dev
This pull request introduces 5 alerts when merging 5f3d21c into 73793b4 - view on LGTM.com new alerts:
|
I'm not sure why LGTM keeps saying there are key conflicts. Looking at the raw source, there are no conflicts... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - the LGTM bot is broken I think. I've seen a similar issue on another PR
Problem:
The AppState API Gateway default endpoints have been hardcoded in the CLI configuration which puts a direct coupling between the CLI configuration and the AppState infrastructure where changes to the API infrastructure would require the CLI to be hot patched.
Solution:
Remove the hardcoded endpoints and replace with deterministic custom domains that do not change.
Testing Done:
yarn setup-dev
Description of changes
Updates config map to use custom domains rather than hard coded API Gateway endpoints
Issue #, if available
N/A
Description of how you validated changes
yarn setup-dev
amplify-dev pull
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.