Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(graphql-relational-transformer): fixed has one and belongs to relationship #8679

Merged
merged 1 commit into from Nov 6, 2021
Merged

fix(graphql-relational-transformer): fixed has one and belongs to relationship #8679

merged 1 commit into from Nov 6, 2021

Conversation

lazpavel
Copy link
Contributor

@lazpavel lazpavel commented Nov 5, 2021 •
edited

Description of changes

  • updates has one and belongs to relationship fields and directive
  • ensure hasOne without fields generates the connected field in the parent object similar to hasOne with fields to create the same developer experience
  • there are second parts PR on the codegen repository here and here

Description of how you validated changes

  • manual testing in a flutter app
  • yarn test passes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lazpavel lazpavel marked this pull request as ready for review November 5, 2021 19:35
@lazpavel lazpavel requested a review from a team as a code owner November 5, 2021 19:35
@lazpavel lazpavel mentioned this pull request Nov 6, 2021
Merged
6 tasks
@lgtm-com
Copy link

lgtm-com bot commented Nov 6, 2021

This pull request introduces 1 alert when merging 93c2337 into 05151bd - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lazpavel lazpavel merged commit 8a390fb into aws-amplify:master Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lazpavel @cjihrig