fix: move @model params to root stack and fix ds logical id #8736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Nov 8, 2021
packages/amplify-graphql-model-transformer/src/__tests__/model-transformer.test.ts
Outdated
Show resolved
Hide resolved
SwaySway
force-pushed
the
modelVNextParams
branch
from
9075680
to
226c72c
Compare
SwaySway
force-pushed
the
modelVNextParams
branch
from
226c72c
to
1a94935
Compare
SwaySway
changed the title
cjihrig
approved these changes
Nov 8, 2021
Codecov Report
@@ Coverage Diff @@
## master #8736 +/- ##
=======================================
Coverage 56.92% 56.92%
=======================================
Files 756 756
Lines 42246 42248 +2
Branches 8659 8659
=======================================
+ Hits 24047 24049 +2
Misses 17378 17378
Partials 821 821
Continue to review full report at Codecov.
|
ammarkarachi
pushed a commit
to ammarkarachi/amplify-cli
that referenced
this pull request
Nov 9, 2021
…ws-amplify#8736)" This reverts commit df4408c.
sachscode
pushed a commit
that referenced
this pull request
Nov 9, 2021
* Revert "fix(amplify-category-auth): added username attributes to configure sms (#8624)" This reverts commit adb70b1. * Revert "Model vnext unit test update (#8749)" This reverts commit 8a308a8. * Revert "Revert "feat: version blocking for CLI (#8737)" (#8747)" This reverts commit 2d5110c. * Revert "chore: update aws-sdk, cdk, typescript dependency, regen yarn.lock (#8739)" This reverts commit d8065a8. * Revert "feat: version blocking for CLI (#8737)" This reverts commit b92cd32. * Revert "Remove pipelineFunction references in favor of resolvers (#8729)" This reverts commit a0295aa. * Revert "fix: move @model params to root stack and fix ds logical id (#8736)" This reverts commit df4408c. * Revert "fix(amplify-provider-awscloudformation): use amplify prompts for warnings (#8731)" This reverts commit 98840ec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
@modelparams to root stackIssue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.