Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert/last green #8759

Merged
merged 8 commits into from
Nov 9, 2021
Merged

Conversation

ammarkarachi
Copy link
Contributor

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ammarkarachi ammarkarachi requested a review from a team as a code owner November 9, 2021 23:09
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the two commits related to version gating can be dropped I think since that is already reverted.

@codecov-commenter
Copy link

Codecov Report

Merging #8759 (6a56b7a) into master (adb70b1) will increase coverage by 0.17%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8759      +/-   ##
==========================================
+ Coverage   57.02%   57.20%   +0.17%     
==========================================
  Files         757      757              
  Lines       42949    42248     -701     
  Branches     9566     8665     -901     
==========================================
- Hits        24491    24166     -325     
- Misses      16544    17267     +723     
+ Partials     1914      815    -1099     
Impacted Files Coverage Δ
...transformer/src/graphql-predictions-transformer.ts 97.80% <ø> (ø)
...-transformer-core/src/cdk-compat/template-asset.ts 26.66% <0.00%> (ø)
...mation/src/graphql-transformer/transform-config.ts 8.00% <ø> (+0.07%) ⬆️
...rc/graphql-transformer/transform-graphql-schema.ts 15.89% <0.00%> (+0.19%) ⬆️
...nsformer/src/RelationalDBSchemaTransformerUtils.ts 100.00% <ø> (ø)
...awscloudformation/src/graphql-transformer/utils.ts 32.78% <57.14%> (-3.87%) ⬇️
...hql-migration-tests/src/nested-stack-diff-rules.ts 90.90% <100.00%> (-0.52%) ⬇️
...wscloudformation/src/utils/sandbox-mode-helpers.ts 100.00% <100.00%> (ø)
...ify-cli/src/extensions/amplify-helpers/get-tags.ts 78.57% <0.00%> (-2.68%) ⬇️
...sformer-migrator/src/migrators/connection/index.ts 80.00% <0.00%> (-1.40%) ⬇️
... and 354 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adb70b1...6a56b7a. Read the comment docs.

@sachscode sachscode merged commit f1c1ee2 into aws-amplify:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants