-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert/last green #8759
Revert/last green #8759
Conversation
…igure sms (aws-amplify#8624)" This reverts commit adb70b1.
This reverts commit 8a308a8.
…ws-amplify#8747)" This reverts commit 2d5110c.
….lock (aws-amplify#8739)" This reverts commit d8065a8.
This reverts commit b92cd32.
…-amplify#8729)" This reverts commit a0295aa.
…ws-amplify#8736)" This reverts commit df4408c.
…for warnings (aws-amplify#8731)" This reverts commit 98840ec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but the two commits related to version gating can be dropped I think since that is already reverted.
Codecov Report
@@ Coverage Diff @@
## master #8759 +/- ##
==========================================
+ Coverage 57.02% 57.20% +0.17%
==========================================
Files 757 757
Lines 42949 42248 -701
Branches 9566 8665 -901
==========================================
- Hits 24491 24166 -325
- Misses 16544 17267 +723
+ Partials 1914 815 -1099
Continue to review full report at Codecov.
|
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.